Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-09-21 15:33:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

pwm: jz4740: Use regmap_{set,clear}_bits

Browse Source 
Simplify a bit the code by using regmap_set_bits() and
regmap_clear_bits() instead of regmap_update_bits() when possible.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
This commit is contained in:
Paul Cercueil 2022-10-24 21:52:13 +01:00 committed by Thierry Reding
parent 69ba53dac3
commit 7d91999954
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/pwm/pwm-jz4740.c
View File

@ -88,8 +88,7 @@ static int jz4740_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
struct jz4740_pwm_chip *jz = to_jz4740(chip); struct jz4740_pwm_chip *jz = to_jz4740(chip);
/* Enable PWM output */ /* Enable PWM output */
regmap_update_bits(jz->map, TCU_REG_TCSRc(pwm->hwpwm), regmap_set_bits(jz->map, TCU_REG_TCSRc(pwm->hwpwm), TCU_TCSR_PWM_EN);
TCU_TCSR_PWM_EN, TCU_TCSR_PWM_EN);
/* Start counter */ /* Start counter */
regmap_write(jz->map, TCU_REG_TESR, BIT(pwm->hwpwm)); regmap_write(jz->map, TCU_REG_TESR, BIT(pwm->hwpwm));
@ -113,8 +112,7 @@ static void jz4740_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
* In TCU2 mode (channel 1/2 on JZ4750+), this must be done before the * In TCU2 mode (channel 1/2 on JZ4750+), this must be done before the
* counter is stopped, while in TCU1 mode the order does not matter. * counter is stopped, while in TCU1 mode the order does not matter.
*/ */
regmap_update_bits(jz->map, TCU_REG_TCSRc(pwm->hwpwm), regmap_clear_bits(jz->map, TCU_REG_TCSRc(pwm->hwpwm), TCU_TCSR_PWM_EN);
TCU_TCSR_PWM_EN, 0);
/* Stop counter */ /* Stop counter */
regmap_write(jz->map, TCU_REG_TECR, BIT(pwm->hwpwm)); regmap_write(jz->map, TCU_REG_TECR, BIT(pwm->hwpwm));
@ -184,8 +182,8 @@ static int jz4740_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
regmap_write(jz4740->map, TCU_REG_TDFRc(pwm->hwpwm), period); regmap_write(jz4740->map, TCU_REG_TDFRc(pwm->hwpwm), period);
/* Set abrupt shutdown */ /* Set abrupt shutdown */
regmap_update_bits(jz4740->map, TCU_REG_TCSRc(pwm->hwpwm), regmap_set_bits(jz4740->map, TCU_REG_TCSRc(pwm->hwpwm),
TCU_TCSR_PWM_SD, TCU_TCSR_PWM_SD); TCU_TCSR_PWM_SD);
/* /*
* Set polarity. * Set polarity.