Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-16 00:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

ip2: fix sparse warnings

Browse Source 
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jiri Slaby 2008-10-13 10:34:45 +01:00 committed by Linus Torvalds
parent cf176bc302
commit 7ccd7020ef
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/char/ip2/ip2main.c
View File

@ -375,9 +375,7 @@ have_requested_irq( char irq )
/* handle subsequent installations of the driver. All memory allocated by the */ /* handle subsequent installations of the driver. All memory allocated by the */
/* driver should be returned since it may be unloaded from memory. */ /* driver should be returned since it may be unloaded from memory. */
/******************************************************************************/ /******************************************************************************/
#ifdef MODULE static void __exit ip2_cleanup_module(void)
void __exit
ip2_cleanup_module(void)
{ {
int err; int err;
int i; int i;
@ -431,7 +429,8 @@ ip2_cleanup_module(void)
ip2config.pci_dev[i] = NULL; ip2config.pci_dev[i] = NULL;
} }
#endif #endif
if ((pB = i2BoardPtrTable[i]) != 0 ) { pB = i2BoardPtrTable[i];
if (pB != NULL) {
kfree ( pB ); kfree ( pB );
i2BoardPtrTable[i] = NULL; i2BoardPtrTable[i] = NULL;
} }
@ -448,7 +447,6 @@ ip2_cleanup_module(void)
#endif #endif
} }
module_exit(ip2_cleanup_module); module_exit(ip2_cleanup_module);
#endif /* MODULE */
static const struct tty_operations ip2_ops = { static const struct tty_operations ip2_ops = {
.open = ip2_open, .open = ip2_open,
@ -1255,9 +1253,8 @@ ip2_polled_interrupt(void)
{ {
int i; int i;
i2eBordStrPtr pB; i2eBordStrPtr pB;
const int irq = 0;
ip2trace (ITRC_NO_PORT, ITRC_INTR, 99, 1, irq ); ip2trace(ITRC_NO_PORT, ITRC_INTR, 99, 1, 0);
/* Service just the boards on the list using this irq */ /* Service just the boards on the list using this irq */
for( i = 0; i < i2nBoards; ++i ) { for( i = 0; i < i2nBoards; ++i ) {
@ -1266,9 +1263,8 @@ ip2_polled_interrupt(void)
// Only process those boards which match our IRQ. // Only process those boards which match our IRQ.
// IRQ = 0 for polled boards, we won't poll "IRQ" boards // IRQ = 0 for polled boards, we won't poll "IRQ" boards
if ( pB && (pB->i2eUsingIrq == irq) ) { if (pB && pB->i2eUsingIrq == 0)
ip2_irq_work(pB); ip2_irq_work(pB);
}
} }
++irq_counter; ++irq_counter;