Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-12 07:01:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

usb: host: oxu210hp-hcd: use list_for_each_entry_safe

Browse Source 
Use list_for_each_entry_safe() instead of list_for_each_safe() to
simplify the code.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Geliang Tang 2015-12-19 00:34:28 +08:00 committed by Greg Kroah-Hartman
parent 553c236057
commit 7b1585f209
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/usb/host/oxu210hp-hcd.c
View File

@ -981,7 +981,7 @@ static int qh_schedule(struct oxu_hcd *oxu, struct ehci_qh *qh);
static unsigned qh_completions(struct oxu_hcd *oxu, struct ehci_qh *qh) static unsigned qh_completions(struct oxu_hcd *oxu, struct ehci_qh *qh)
{ {
struct ehci_qtd *last = NULL, *end = qh->dummy; struct ehci_qtd *last = NULL, *end = qh->dummy;
struct list_head *entry, *tmp; struct ehci_qtd *qtd, *tmp;
int stopped; int stopped;
unsigned count = 0; unsigned count = 0;
int do_status = 0; int do_status = 0;
@ -1006,12 +1006,10 @@ static unsigned qh_completions(struct oxu_hcd *oxu, struct ehci_qh *qh)
* then let the queue advance. * then let the queue advance.
* if queue is stopped, handles unlinks. * if queue is stopped, handles unlinks.
*/ */
list_for_each_safe(entry, tmp, &qh->qtd_list) { list_for_each_entry_safe(qtd, tmp, &qh->qtd_list, qtd_list) {
struct ehci_qtd *qtd;
struct urb *urb; struct urb *urb;
u32 token = 0; u32 token = 0;
qtd = list_entry(entry, struct ehci_qtd, qtd_list);
urb = qtd->urb; urb = qtd->urb;
/* Clean up any state from previous QTD ...*/ /* Clean up any state from previous QTD ...*/
@ -1174,14 +1172,11 @@ halt:
* used for cleanup after errors, before HC sees an URB's TDs. * used for cleanup after errors, before HC sees an URB's TDs.
*/ */
static void qtd_list_free(struct oxu_hcd *oxu, static void qtd_list_free(struct oxu_hcd *oxu,
struct urb *urb, struct list_head *qtd_list) struct urb *urb, struct list_head *head)
{ {
struct list_head *entry, *temp; struct ehci_qtd *qtd, *temp;
list_for_each_safe(entry, temp, qtd_list) { list_for_each_entry_safe(qtd, temp, head, qtd_list) {
struct ehci_qtd *qtd;
qtd = list_entry(entry, struct ehci_qtd, qtd_list);
list_del(&qtd->qtd_list); list_del(&qtd->qtd_list);
oxu_qtd_free(oxu, qtd); oxu_qtd_free(oxu, qtd);
} }