Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-09-23 16:33:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

remoteproc: Reduce asynchronous request_firmware to auto-boot only

Browse Source 
The rproc_add_virtio_devices() requests firmware asynchronously and
triggers boot if the auto_boot flag is set. However, this
asynchronous call seems to be redundant for non auto-boot scenario
since the rproc_boot() would call request_firmware() anyways. Move
the auto_boot check to rproc_add() so that a redundant call to
_request_firmware can be avoided for non auto-boot case.

Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
This commit is contained in:
Sarangdhar Joshi 2017-01-24 15:13:00 -08:00 committed by Bjorn Andersson
parent 66a66aa74e
commit 7a20c64ddb
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/remoteproc/remoteproc_core.c
View File

@ -972,9 +972,7 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context)
{
struct rproc *rproc = context;
/* if rproc is marked always-on, request it to boot */
if (rproc->auto_boot)
rproc_boot(rproc);
rproc_boot(rproc);
release_firmware(fw);
}
@ -1286,9 +1284,13 @@ int rproc_add(struct rproc *rproc)
/* create debugfs entries */
rproc_create_debug_dir(rproc);
ret = rproc_add_virtio_devices(rproc);
if (ret < 0)
return ret;
/* if rproc is marked always-on, request it to boot */
if (rproc->auto_boot) {
ret = rproc_add_virtio_devices(rproc);
if (ret < 0)
return ret;
}
/* expose to rproc_get_by_phandle users */
mutex_lock(&rproc_list_mutex);