Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-28 05:41:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

xen/pvcalls: remove redundant check for irq >= 0

Browse Source 
This is a moot point, but irq is always less than zero at the label
out_error, so the check for irq >= 0 is redundant and can be removed.

Detected by CoverityScan, CID#1460371 ("Logically dead code")

Fixes: cb1c7d9bbc ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
This commit is contained in:
Colin Ian King 2017-11-03 09:20:47 +00:00 committed by Boris Ostrovsky
parent 95110ac88d
commit 773aaadcd4
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/xen/pvcalls-front.c
View File

@ -351,9 +351,7 @@ static int create_active(struct sock_mapping *map, int *evtchn)
return 0;
out_error:
if (irq >= 0)
unbind_from_irqhandler(irq, map);
else if (*evtchn >= 0)
if (*evtchn >= 0)
xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
kfree(map->active.data.in);
kfree(map->active.ring);