mirror of
https://github.com/torvalds/linux.git
synced 2024-11-11 06:31:49 +00:00
HID: fix picolcd's version parsing
During grouping of version checking code bootloader mode's version bytes got swapped. Fix their order. Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
parent
5435f2818e
commit
76d17e6ca3
@ -1196,16 +1196,14 @@ static int picolcd_check_version(struct hid_device *hdev)
|
||||
}
|
||||
|
||||
if (verinfo->raw_size == 2) {
|
||||
data->version[0] = verinfo->raw_data[1];
|
||||
data->version[1] = verinfo->raw_data[0];
|
||||
if (data->status & PICOLCD_BOOTLOADER) {
|
||||
dev_info(&hdev->dev, "PicoLCD, bootloader version %d.%d\n",
|
||||
verinfo->raw_data[0], verinfo->raw_data[1]);
|
||||
data->version[0] = verinfo->raw_data[0];
|
||||
data->version[1] = verinfo->raw_data[1];
|
||||
verinfo->raw_data[1], verinfo->raw_data[0]);
|
||||
} else {
|
||||
dev_info(&hdev->dev, "PicoLCD, firmware version %d.%d\n",
|
||||
verinfo->raw_data[1], verinfo->raw_data[0]);
|
||||
data->version[0] = verinfo->raw_data[1];
|
||||
data->version[1] = verinfo->raw_data[0];
|
||||
}
|
||||
} else {
|
||||
dev_err(&hdev->dev, "confused, got unexpected version response from PicoLCD\n");
|
||||
|
Loading…
Reference in New Issue
Block a user