Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-17 01:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

x86/amd-iommu: enable iommu before attaching devices

Browse Source 
Hit another kdump problem as reported by Neil Horman.  When initializaing
the IOMMU, we attach devices to their domains before the IOMMU is
fully (re)initialized.  Attaching a device will issue some important
invalidations.  In the context of the newly kexec'd kdump kernel, the
IOMMU may have stale cached data from the original kernel.  Because we
do the attach too early, the invalidation commands are placed in the new
command buffer before the IOMMU is updated w/ that buffer.  This leaves
the stale entries in the kdump context and can renders device unusable.
Simply enable the IOMMU before we do the attach.

Cc: stable@kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
This commit is contained in:
Chris Wright 2010-04-02 18:27:52 -07:00 committed by Joerg Roedel
parent 8b408fe4f8
commit 75f66533bc
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
arch/x86/kernel/amd_iommu_init.c
View File

@ -1304,6 +1304,8 @@ static int __init amd_iommu_init(void)
if (ret)
goto free;
enable_iommus();
if (iommu_pass_through)
ret = amd_iommu_init_passthrough();
else
@ -1316,8 +1318,6 @@ static int __init amd_iommu_init(void)
amd_iommu_init_notifier();
enable_iommus();
if (iommu_pass_through)
goto out;
@ -1331,6 +1331,7 @@ out:
return ret;
free:
disable_iommus();
amd_iommu_uninit_devices();