mirror of
https://github.com/torvalds/linux.git
synced 2024-09-21 07:23:06 +00:00
scsi: lpfc: Replace all non-returning strlcpy() with strscpy()
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Link: https://lore.kernel.org/r/20230530155745.343032-1-azeemshaikh38@gmail.com Reviewed-by: Justin Tee <justin.tee@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
8f0c17bf6b
commit
73be26b12d
|
@ -4836,7 +4836,7 @@ lpfc_nlp_state_name(char *buffer, size_t size, int state)
|
|||
};
|
||||
|
||||
if (state < NLP_STE_MAX_STATE && states[state])
|
||||
strlcpy(buffer, states[state], size);
|
||||
strscpy(buffer, states[state], size);
|
||||
else
|
||||
snprintf(buffer, size, "unknown (%d)", state);
|
||||
return buffer;
|
||||
|
|
Loading…
Reference in New Issue
Block a user