Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-28 13:51:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

eeprom: idt_89hpesx: uninitialized data in idt_dbgfs_csr_write()

Browse Source 
The simple_write_to_buffer() function will return positive/success if it
is able to write a single byte anywhere within the buffer.  However that
potentially leaves a lot of the buffer uninitialized.

In this code it's better to return 0 if the offset is non-zero.  This
code is not written to support partial writes.  And then return -EFAULT
if the buffer is not completely initialized.

Fixes: cfad642538 ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Ysg1Pu/nzSMe3r1q@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2022-07-08 16:46:38 +03:00 committed by Greg Kroah-Hartman
parent 2a3c8f8a44
commit 71d46f1ff2
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/misc/eeprom/idt_89hpesx.c
View File

@ -909,14 +909,18 @@ static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf,
u32 csraddr, csrval; u32 csraddr, csrval;
char *buf; char *buf;
if (*offp)
return 0;
/* Copy data from User-space */ /* Copy data from User-space */
buf = kmalloc(count + 1, GFP_KERNEL); buf = kmalloc(count + 1, GFP_KERNEL);
if (!buf) if (!buf)
return -ENOMEM; return -ENOMEM;
ret = simple_write_to_buffer(buf, count, offp, ubuf, count); if (copy_from_user(buf, ubuf, count)) {
if (ret < 0) ret = -EFAULT;
goto free_buf; goto free_buf;
}
buf[count] = 0; buf[count] = 0;
/* Find position of colon in the buffer */ /* Find position of colon in the buffer */