mirror of
https://github.com/torvalds/linux.git
synced 2024-09-21 15:33:19 +00:00
video/fbdev/dnfb: Use common error handling code in dnfb_probe()
Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
This commit is contained in:
parent
ffb66624ca
commit
6b04e9f256
|
@ -242,16 +242,13 @@ static int dnfb_probe(struct platform_device *dev)
|
||||||
info->screen_base = (u_char *) info->fix.smem_start;
|
info->screen_base = (u_char *) info->fix.smem_start;
|
||||||
|
|
||||||
err = fb_alloc_cmap(&info->cmap, 2, 0);
|
err = fb_alloc_cmap(&info->cmap, 2, 0);
|
||||||
if (err < 0) {
|
if (err < 0)
|
||||||
framebuffer_release(info);
|
goto release_framebuffer;
|
||||||
return err;
|
|
||||||
}
|
|
||||||
|
|
||||||
err = register_framebuffer(info);
|
err = register_framebuffer(info);
|
||||||
if (err < 0) {
|
if (err < 0) {
|
||||||
fb_dealloc_cmap(&info->cmap);
|
fb_dealloc_cmap(&info->cmap);
|
||||||
framebuffer_release(info);
|
goto release_framebuffer;
|
||||||
return err;
|
|
||||||
}
|
}
|
||||||
platform_set_drvdata(dev, info);
|
platform_set_drvdata(dev, info);
|
||||||
|
|
||||||
|
@ -265,6 +262,10 @@ static int dnfb_probe(struct platform_device *dev)
|
||||||
|
|
||||||
printk("apollo frame buffer alive and kicking !\n");
|
printk("apollo frame buffer alive and kicking !\n");
|
||||||
return err;
|
return err;
|
||||||
|
|
||||||
|
release_framebuffer:
|
||||||
|
framebuffer_release(info);
|
||||||
|
return err;
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct platform_driver dnfb_driver = {
|
static struct platform_driver dnfb_driver = {
|
||||||
|
|
Loading…
Reference in New Issue
Block a user