Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 14:42:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

vfio/mdev: Re-order sysfs attribute creation

Browse Source 
There exists a gap at the end of mdev_device_create() where the device
is visible to userspace, but we're not yet ready to handle removal, as
triggered through the 'remove' attribute.  We handle this properly in
mdev_device_remove() with an -EAGAIN return, but we can marginally
reduce this gap by adding this attribute as a final step of our sysfs
setup.

Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
Alex Williamson 2018-05-18 11:40:33 -06:00
parent 002fe996f6
commit 6a62c1dfb5
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/vfio/mdev/mdev_sysfs.c
View File

@ -257,24 +257,24 @@ int mdev_create_sysfs_files(struct device *dev, struct mdev_type *type)
{ {
int ret; int ret;
ret = sysfs_create_files(&dev->kobj, mdev_device_attrs);
if (ret)
return ret;
ret = sysfs_create_link(type->devices_kobj, &dev->kobj, dev_name(dev)); ret = sysfs_create_link(type->devices_kobj, &dev->kobj, dev_name(dev));
if (ret) if (ret)
goto device_link_failed; return ret;
ret = sysfs_create_link(&dev->kobj, &type->kobj, "mdev_type"); ret = sysfs_create_link(&dev->kobj, &type->kobj, "mdev_type");
if (ret) if (ret)
goto type_link_failed; goto type_link_failed;
ret = sysfs_create_files(&dev->kobj, mdev_device_attrs);
if (ret)
goto create_files_failed;
return ret; return ret;
create_files_failed:
sysfs_remove_link(&dev->kobj, "mdev_type");
type_link_failed: type_link_failed:
sysfs_remove_link(type->devices_kobj, dev_name(dev)); sysfs_remove_link(type->devices_kobj, dev_name(dev));
device_link_failed:
sysfs_remove_files(&dev->kobj, mdev_device_attrs);
return ret; return ret;
} }