Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

erofs: Revert "erofs: fix kvcalloc() misuse with __GFP_NOFAIL"

Browse Source 
Let's revert commit 12724ba389 ("erofs: fix kvcalloc() misuse with
__GFP_NOFAIL") since kvmalloc() already supports __GFP_NOFAIL in commit
a421ef3030 ("mm: allow !GFP_KERNEL allocations for kvmalloc").  So
the original fix was wrong.

Actually there was some issue as [1] discussed, so before that mm fix
is landed, the warn could still happen but applying this commit first
will cause less.

[1] https://lore.kernel.org/r/20230305053035.1911-1-hsiangkao@linux.alibaba.com

Fixes: 12724ba389 ("erofs: fix kvcalloc() misuse with __GFP_NOFAIL")
Reviewed-by: Chao Yu <chao@kernel.org>
Link: https://lore.kernel.org/r/20230309053148.9223-1-hsiangkao@linux.alibaba.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
This commit is contained in:
Gao Xiang 2023-03-09 13:31:47 +08:00
parent 8f121dfb15
commit 647dd2c3f0
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/erofs/zdata.c
View File

@ -1312,11 +1312,11 @@ static int z_erofs_decompress_pcluster(struct z_erofs_decompress_backend *be,
if (!be->decompressed_pages) if (!be->decompressed_pages)
be->decompressed_pages = be->decompressed_pages =
kcalloc(be->nr_pages, sizeof(struct page *), kvcalloc(be->nr_pages, sizeof(struct page *),
GFP_KERNEL | __GFP_NOFAIL); GFP_KERNEL | __GFP_NOFAIL);
if (!be->compressed_pages) if (!be->compressed_pages)
be->compressed_pages = be->compressed_pages =
kcalloc(pclusterpages, sizeof(struct page *), kvcalloc(pclusterpages, sizeof(struct page *),
GFP_KERNEL | __GFP_NOFAIL); GFP_KERNEL | __GFP_NOFAIL);
z_erofs_parse_out_bvecs(be); z_erofs_parse_out_bvecs(be);
@ -1365,7 +1365,7 @@ out:
} }
if (be->compressed_pages < be->onstack_pages || if (be->compressed_pages < be->onstack_pages ||
be->compressed_pages >= be->onstack_pages + Z_EROFS_ONSTACK_PAGES) be->compressed_pages >= be->onstack_pages + Z_EROFS_ONSTACK_PAGES)
kfree(be->compressed_pages); kvfree(be->compressed_pages);
z_erofs_fill_other_copies(be, err); z_erofs_fill_other_copies(be, err);
for (i = 0; i < be->nr_pages; ++i) { for (i = 0; i < be->nr_pages; ++i) {
@ -1384,7 +1384,7 @@ out:
} }
if (be->decompressed_pages != be->onstack_pages) if (be->decompressed_pages != be->onstack_pages)
kfree(be->decompressed_pages); kvfree(be->decompressed_pages);
pcl->length = 0; pcl->length = 0;
pcl->partial = true; pcl->partial = true;