Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-09-23 00:13:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: genwqe: fix return value check in genwqe_device_create()

Browse Source 
In case of error, the function device_create_with_groups()
returns ERR_PTR() and never returns NULL. The NULL test in
the return value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2014-01-07 16:56:35 +08:00 committed by Greg Kroah-Hartman
parent 3c1547e774
commit 634608f27a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/genwqe/card_dev.c
View File

@ -1306,8 +1306,8 @@ int genwqe_device_create(struct genwqe_dev *cd)
genwqe_attribute_groups,
GENWQE_DEVNAME "%u_card",
cd->card_idx);
if (cd->dev == NULL) {
rc = -ENODEV;
if (IS_ERR(cd->dev)) {
rc = PTR_ERR(cd->dev);
goto err_cdev;
}