Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-18 10:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

cppc_cpufreq: fix misspelling, code style and readability issues

Browse Source 
Fix a few trivial issues in the cppc_cpufreq driver:

 - indentation of function arguments
 - consistent use of tabs (vs space) in defines
 - spelling: s/Offest/Offset, s/trasition/transition
 - order of local variables, from long pointers to structures to
   short ret and i (index) variables, to improve readability

Signed-off-by: Ionela Voinescu <ionela.voinescu@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Ionela Voinescu 2020-11-05 12:55:17 +00:00 committed by Rafael J. Wysocki
parent ef7ece9a9b
commit 63087265c2
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
drivers/cpufreq/cppc_cpufreq.c
View File

@ -26,8 +26,8 @@
/* Minimum struct length needed for the DMI processor entry we want */ /* Minimum struct length needed for the DMI processor entry we want */
#define DMI_ENTRY_PROCESSOR_MIN_LENGTH 48 #define DMI_ENTRY_PROCESSOR_MIN_LENGTH 48
/* Offest in the DMI processor structure for the max frequency */ /* Offset in the DMI processor structure for the max frequency */
#define DMI_PROCESSOR_MAX_SPEED 0x14 #define DMI_PROCESSOR_MAX_SPEED 0x14
/* /*
* These structs contain information parsed from per CPU * These structs contain information parsed from per CPU
@ -97,10 +97,10 @@ static u64 cppc_get_dmi_max_khz(void)
* For perf/freq > Nominal, we use the ratio perf:freq at Nominal for conversion * For perf/freq > Nominal, we use the ratio perf:freq at Nominal for conversion
*/ */
static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu, static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu,
unsigned int perf) unsigned int perf)
{ {
static u64 max_khz;
struct cppc_perf_caps *caps = &cpu->perf_caps; struct cppc_perf_caps *caps = &cpu->perf_caps;
static u64 max_khz;
u64 mul, div; u64 mul, div;
if (caps->lowest_freq && caps->nominal_freq) { if (caps->lowest_freq && caps->nominal_freq) {
@ -121,10 +121,10 @@ static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu,
} }
static unsigned int cppc_cpufreq_khz_to_perf(struct cppc_cpudata *cpu, static unsigned int cppc_cpufreq_khz_to_perf(struct cppc_cpudata *cpu,
unsigned int freq) unsigned int freq)
{ {
static u64 max_khz;
struct cppc_perf_caps *caps = &cpu->perf_caps; struct cppc_perf_caps *caps = &cpu->perf_caps;
static u64 max_khz;
u64 mul, div; u64 mul, div;
if (caps->lowest_freq && caps->nominal_freq) { if (caps->lowest_freq && caps->nominal_freq) {
@ -146,11 +146,11 @@ static unsigned int cppc_cpufreq_khz_to_perf(struct cppc_cpudata *cpu,
} }
static int cppc_cpufreq_set_target(struct cpufreq_policy *policy, static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
unsigned int target_freq, unsigned int target_freq,
unsigned int relation) unsigned int relation)
{ {
struct cppc_cpudata *cpu;
struct cpufreq_freqs freqs; struct cpufreq_freqs freqs;
struct cppc_cpudata *cpu;
u32 desired_perf; u32 desired_perf;
int ret = 0; int ret = 0;
@ -171,7 +171,7 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
if (ret) if (ret)
pr_debug("Failed to set target on CPU:%d. ret:%d\n", pr_debug("Failed to set target on CPU:%d. ret:%d\n",
cpu->cpu, ret); cpu->cpu, ret);
return ret; return ret;
} }
@ -193,13 +193,13 @@ static void cppc_cpufreq_stop_cpu(struct cpufreq_policy *policy)
ret = cppc_set_perf(cpu_num, &cpu->perf_ctrls); ret = cppc_set_perf(cpu_num, &cpu->perf_ctrls);
if (ret) if (ret)
pr_debug("Err setting perf value:%d on CPU:%d. ret:%d\n", pr_debug("Err setting perf value:%d on CPU:%d. ret:%d\n",
cpu->perf_caps.lowest_perf, cpu_num, ret); cpu->perf_caps.lowest_perf, cpu_num, ret);
} }
/* /*
* The PCC subspace describes the rate at which platform can accept commands * The PCC subspace describes the rate at which platform can accept commands
* on the shared PCC channel (including READs which do not count towards freq * on the shared PCC channel (including READs which do not count towards freq
* trasition requests), so ideally we need to use the PCC values as a fallback * transition requests), so ideally we need to use the PCC values as a fallback
* if we don't have a platform specific transition_delay_us * if we don't have a platform specific transition_delay_us
*/ */
#ifdef CONFIG_ARM64 #ifdef CONFIG_ARM64
@ -241,8 +241,8 @@ static unsigned int cppc_cpufreq_get_transition_delay_us(int cpu)
static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy)
{ {
struct cppc_cpudata *cpu;
unsigned int cpu_num = policy->cpu; unsigned int cpu_num = policy->cpu;
struct cppc_cpudata *cpu;
int ret = 0; int ret = 0;
cpu = all_cpu_data[policy->cpu]; cpu = all_cpu_data[policy->cpu];
@ -252,7 +252,7 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy)
if (ret) { if (ret) {
pr_debug("Err reading CPU%d perf capabilities. ret:%d\n", pr_debug("Err reading CPU%d perf capabilities. ret:%d\n",
cpu_num, ret); cpu_num, ret);
return ret; return ret;
} }
@ -313,7 +313,7 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy)
ret = cppc_set_perf(cpu_num, &cpu->perf_ctrls); ret = cppc_set_perf(cpu_num, &cpu->perf_ctrls);
if (ret) if (ret)
pr_debug("Err setting perf value:%d on CPU:%d. ret:%d\n", pr_debug("Err setting perf value:%d on CPU:%d. ret:%d\n",
cpu->perf_caps.highest_perf, cpu_num, ret); cpu->perf_caps.highest_perf, cpu_num, ret);
return ret; return ret;
} }
@ -450,8 +450,8 @@ static void cppc_check_hisi_workaround(void)
static int __init cppc_cpufreq_init(void) static int __init cppc_cpufreq_init(void)
{ {
int i, ret = 0;
struct cppc_cpudata *cpu; struct cppc_cpudata *cpu;
int i, ret = 0;
if (acpi_disabled) if (acpi_disabled)
return -ENODEV; return -ENODEV;