ASN.1: Fix check for strdup() success

It seems there is a misprint in the check of strdup() return code that
can lead to NULL pointer dereference.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 4520c6a49a ("X.509: Add simple ASN.1 grammar compiler")
Signed-off-by: Ekaterina Orlova <vorobushek.ok@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: keyrings@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org
Link: https://lore.kernel.org/r/20230315172130.140-1-vorobushek.ok@gmail.com/
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Ekaterina Orlova 2023-04-21 15:35:39 +01:00 committed by Linus Torvalds
parent 2af3e53a4d
commit 5a43001c01

View File

@ -625,7 +625,7 @@ int main(int argc, char **argv)
p = strrchr(argv[1], '/'); p = strrchr(argv[1], '/');
p = p ? p + 1 : argv[1]; p = p ? p + 1 : argv[1];
grammar_name = strdup(p); grammar_name = strdup(p);
if (!p) { if (!grammar_name) {
perror(NULL); perror(NULL);
exit(1); exit(1);
} }