Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-30 14:52:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

scsi: a3000: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

In the error path emit an error message replacing the (less useful)
message by the core. Apart from the improved error message there is no
change in behaviour.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/811d180950b76c2d95cd080e3c251757ca011380.1701619134.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Uwe Kleine-König 2023-12-03 17:05:46 +01:00 committed by Martin K. Petersen
parent b85ea95d08
commit 5854cdd041
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/scsi/a3000.c
View File

@ -282,7 +282,7 @@ fail_alloc:
return error; return error;
} }
static int __exit amiga_a3000_scsi_remove(struct platform_device *pdev) static void __exit amiga_a3000_scsi_remove(struct platform_device *pdev)
{ {
struct Scsi_Host *instance = platform_get_drvdata(pdev); struct Scsi_Host *instance = platform_get_drvdata(pdev);
struct a3000_hostdata *hdata = shost_priv(instance); struct a3000_hostdata *hdata = shost_priv(instance);
@ -293,11 +293,10 @@ static int __exit amiga_a3000_scsi_remove(struct platform_device *pdev)
free_irq(IRQ_AMIGA_PORTS, instance); free_irq(IRQ_AMIGA_PORTS, instance);
scsi_host_put(instance); scsi_host_put(instance);
release_mem_region(res->start, resource_size(res)); release_mem_region(res->start, resource_size(res));
return 0;
} }
static struct platform_driver amiga_a3000_scsi_driver = { static struct platform_driver amiga_a3000_scsi_driver = {
.remove = __exit_p(amiga_a3000_scsi_remove), .remove_new = __exit_p(amiga_a3000_scsi_remove),
.driver = { .driver = {
.name = "amiga-a3000-scsi", .name = "amiga-a3000-scsi",
}, },