Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-09-24 00:43:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf header: Fix double fclose() on do_write(fd, xxx) failure

Browse Source 
cppcheck reported:
[util/header.c:983]: (error) Used file that is not opened.

Thanks to Arnaldo Carvalho de Melo for pointing out that
fclose(NULL) is undefined behavior -> protect against it.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Link: http://lkml.kernel.org/r/1751778.SZQB4fNdIh@storm
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Thomas Jarosch 2013-01-28 10:21:14 +01:00 committed by Arnaldo Carvalho de Melo
parent fdae637391
commit 5809fde040
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/perf/util/header.c
View File

@ -955,6 +955,7 @@ static int write_topo_node(int fd, int node)
}
fclose(fp);
fp = NULL;
ret = do_write(fd, &mem_total, sizeof(u64));
if (ret)
@ -981,7 +982,8 @@ static int write_topo_node(int fd, int node)
ret = do_write_string(fd, buf);
done:
free(buf);
fclose(fp);
if (fp)
fclose(fp);
return ret;
}