Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-26 21:02:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

hwmon: (asus-ec-sensors) do not print from .probe()

Browse Source 
Remove the call to dev_info() from the board detection function, which
is called from probe(), not only to be in line with hwmon driver rules, but
also because the message duplicates the error code returned from probe()
for that case (ENODEV).

Changes in:
 - v2: add missing newline (style).

Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
Link: https://lore.kernel.org/r/20220217194318.2960472-1-eugene.shalygin@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Eugene Shalygin 2022-02-17 20:43:18 +01:00 committed by Guenter Roeck
parent da78ad2b6b
commit 567e77a2c2
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/hwmon/asus-ec-sensors.c
View File

@ -597,18 +597,12 @@ static struct hwmon_chip_info asus_ec_chip_info = {
.ops = &asus_ec_hwmon_ops,
};
static unsigned long __init
get_board_sensors(const struct device *dev)
static unsigned long __init get_board_sensors(void)
{
const struct dmi_system_id *dmi_entry;
const struct dmi_system_id *dmi_entry =
dmi_first_match(asus_ec_dmi_table);
dmi_entry = dmi_first_match(asus_ec_dmi_table);
if (!dmi_entry) {
dev_info(dev, "Unsupported board");
return 0;
}
return (unsigned long)dmi_entry->driver_data;
return dmi_entry ? (unsigned long)dmi_entry->driver_data : 0;
}
static int __init asus_ec_probe(struct platform_device *pdev)
@ -625,7 +619,7 @@ static int __init asus_ec_probe(struct platform_device *pdev)
struct device *hwdev;
unsigned int i;
board_sensors = get_board_sensors(dev);
board_sensors = get_board_sensors();
if (!board_sensors)
return -ENODEV;