Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 14:11:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

dma-mapping: don't return errors from dma_set_seg_boundary

Browse Source 
A NULL dev->dma_parms indicates either a bus that is not DMA capable or
grave bug in the implementation of the bus code.

There isn't much the driver can do in terms of error handling for either
case, so just warn and continue as DMA operations will fail anyway.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Christoph Hellwig 2024-07-19 06:06:28 +02:00
parent c42a01264b
commit 560a861ab4
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
include/linux/dma-mapping.h
View File

@ -559,13 +559,11 @@ static inline unsigned long dma_get_seg_boundary_nr_pages(struct device *dev,
return (dma_get_seg_boundary(dev) >> page_shift) + 1; return (dma_get_seg_boundary(dev) >> page_shift) + 1;
} }
static inline int dma_set_seg_boundary(struct device *dev, unsigned long mask) static inline void dma_set_seg_boundary(struct device *dev, unsigned long mask)
{ {
if (dev->dma_parms) { if (WARN_ON_ONCE(!dev->dma_parms))
dev->dma_parms->segment_boundary_mask = mask; return;
return 0; dev->dma_parms->segment_boundary_mask = mask;
}
return -EIO;
} }
static inline unsigned int dma_get_min_align_mask(struct device *dev) static inline unsigned int dma_get_min_align_mask(struct device *dev)