Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 14:11:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

staging: rtl8192u: Fix keyidx assignment within if condition

Browse Source 
Refactor the if condition into nested conditionals to improve clarity.
The condition is currently in the form of (E1 && E2 && E3), where the
variable keyidx is assigned a value in E3.

Signed-off-by: Wang Jinchao <wangjinchao600@gmail.com>
Link: https://lore.kernel.org/r/ZKQ7tYa9I+PHgef/@fedora
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wang Jinchao 2023-07-04 23:33:09 +08:00 committed by Greg Kroah-Hartman
parent 405f3d102c
commit 5492ed9f8f
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
View File

@ -1121,10 +1121,12 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct sk_buff *skb,
/* skb: hdr + (possibly fragmented, possibly encrypted) payload */
if (ieee->host_decrypt && (fc & IEEE80211_FCTL_WEP) &&
(keyidx = ieee80211_rx_frame_decrypt(ieee, skb, crypt)) < 0) {
netdev_dbg(ieee->dev, "decrypt frame error\n");
goto rx_dropped;
if (ieee->host_decrypt && (fc & IEEE80211_FCTL_WEP)) {
keyidx = ieee80211_rx_frame_decrypt(ieee, skb, crypt);
if (keyidx < 0) {
netdev_dbg(ieee->dev, "decrypt frame error\n");
goto rx_dropped;
}
}