Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-26 12:52:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

coccinelle: api: extend memdup_user transformation with GFP_USER

Browse Source 
Match GFP_USER and optional __GFP_NOWARN allocations with
memdup_user.cocci rule.
Commit 6c2c97a24f ("memdup_user(): switch to GFP_USER") switched
memdup_user() from GFP_KERNEL to GFP_USER. In almost all cases it
is still a good idea to recommend memdup_user() for GFP_KERNEL
allocations. The motivation behind altering memdup_user() to GFP_USER:
https://lkml.org/lkml/2018/1/6/333

Signed-off-by: Denis Efremov <efremov@linux.com>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
This commit is contained in:
Denis Efremov 2020-07-20 19:22:14 +03:00 committed by Julia Lawall
parent 7cf4be68b1
commit 547ade42ce
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/coccinelle/api/memdup_user.cocci
View File

@ -20,7 +20,9 @@ expression from,to,size;
identifier l1,l2; identifier l1,l2;
@@ @@
- to = \(kmalloc\|kzalloc\)(size,GFP_KERNEL); - to = \(kmalloc\|kzalloc\)
- (size,\(GFP_KERNEL\|GFP_USER\|
- \(GFP_KERNEL\|GFP_USER\)|__GFP_NOWARN\));
+ to = memdup_user(from,size); + to = memdup_user(from,size);
if ( if (
- to==NULL - to==NULL
@ -43,7 +45,9 @@ position p;
statement S1,S2; statement S1,S2;
@@ @@
* to = \(kmalloc@p\|kzalloc@p\)(size,GFP_KERNEL); * to = \(kmalloc@p\|kzalloc@p\)
(size,\(GFP_KERNEL\|GFP_USER\|
\(GFP_KERNEL\|GFP_USER\)|__GFP_NOWARN\));
if (to==NULL || ...) S1 if (to==NULL || ...) S1
if (copy_from_user(to, from, size) != 0) if (copy_from_user(to, from, size) != 0)
S2 S2