Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 22:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

usb: gadget: r8a66597-udc: use devm_kzalloc() to allocate driver state

Browse Source 
Update driver to use devm_kzalloc() to make tracking of resources
easier. Also remove the exit point via cleanup as there's no
cleanup necessary from this point now.

As a note, also removes the error print as the allocation calls
produce errors if they do not return memory.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Ben Dooks 2014-06-17 16:14:56 +01:00 committed by Felipe Balbi
parent f390f57c91
commit 531bc938f9
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/usb/gadget/r8a66597-udc.c
View File

@ -1836,7 +1836,6 @@ static int __exit r8a66597_remove(struct platform_device *pdev)
clk_put(r8a66597->clk);
}
kfree(r8a66597);
return 0;
}
@ -1892,11 +1891,9 @@ static int __init r8a66597_probe(struct platform_device *pdev)
}
/* initialize ucd */
r8a66597 = kzalloc(sizeof(struct r8a66597), GFP_KERNEL);
if (r8a66597 == NULL) {
ret = -ENOMEM;
goto clean_up;
}
r8a66597 = devm_kzalloc(dev, sizeof(struct r8a66597), GFP_KERNEL);
if (r8a66597 == NULL)
return -ENOMEM;
spin_lock_init(&r8a66597->lock);
platform_set_drvdata(pdev, r8a66597);
@ -1995,7 +1992,6 @@ clean_up:
if (r8a66597->ep0_req)
r8a66597_free_request(&r8a66597->ep[0].ep,
r8a66597->ep0_req);
kfree(r8a66597);
}
return ret;