mirror of
https://github.com/torvalds/linux.git
synced 2024-11-14 08:02:07 +00:00
lightnvm: move the pages per block check out of the loop
There is no need to check whether dev's pages per block is beyond rrpc support every time we init a lun, we only need to check it once before enter the lun init loop. Signed-off-by: Wenwei Tao <ww.tao0320@gmail.com> Signed-off-by: Matias Bjørling <m@bjorling.me> Signed-off-by: Jens Axboe <axboe@fb.com>
This commit is contained in:
parent
556755e941
commit
4b79beb4c3
@ -1114,6 +1114,11 @@ static int rrpc_luns_init(struct rrpc *rrpc, int lun_begin, int lun_end)
|
||||
struct rrpc_lun *rlun;
|
||||
int i, j;
|
||||
|
||||
if (dev->pgs_per_blk > MAX_INVALID_PAGES_STORAGE * BITS_PER_LONG) {
|
||||
pr_err("rrpc: number of pages per block too high.");
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
spin_lock_init(&rrpc->rev_lock);
|
||||
|
||||
rrpc->luns = kcalloc(rrpc->nr_luns, sizeof(struct rrpc_lun),
|
||||
@ -1125,12 +1130,6 @@ static int rrpc_luns_init(struct rrpc *rrpc, int lun_begin, int lun_end)
|
||||
for (i = 0; i < rrpc->nr_luns; i++) {
|
||||
struct nvm_lun *lun = dev->mt->get_lun(dev, lun_begin + i);
|
||||
|
||||
if (dev->pgs_per_blk >
|
||||
MAX_INVALID_PAGES_STORAGE * BITS_PER_LONG) {
|
||||
pr_err("rrpc: number of pages per block too high.");
|
||||
goto err;
|
||||
}
|
||||
|
||||
rlun = &rrpc->luns[i];
|
||||
rlun->rrpc = rrpc;
|
||||
rlun->parent = lun;
|
||||
|
Loading…
Reference in New Issue
Block a user