mirror of
https://github.com/torvalds/linux.git
synced 2024-09-20 23:13:00 +00:00
ALSA: hda: cs35l41: Fix unbalanced pm_runtime_get()
If component_add() fails, probe() returns without calling
pm_runtime_put(), which leaves the runtime PM usage counter incremented.
Fix the issue by jumping to err_pm label and drop the now unnecessary
pm_runtime_disable() call.
Fixes: 7b2f3eb492
("ALSA: hda: cs35l41: Add support for CS35L41 in HDA systems")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20230907171010.1447274-10-cristian.ciocaltea@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
611b8813a2
commit
486465508f
|
@ -1625,8 +1625,7 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i
|
|||
ret = component_add(cs35l41->dev, &cs35l41_hda_comp_ops);
|
||||
if (ret) {
|
||||
dev_err(cs35l41->dev, "Register component failed: %d\n", ret);
|
||||
pm_runtime_disable(cs35l41->dev);
|
||||
goto err;
|
||||
goto err_pm;
|
||||
}
|
||||
|
||||
dev_info(cs35l41->dev, "Cirrus Logic CS35L41 (%x), Revision: %02X\n", regid, reg_revid);
|
||||
|
|
Loading…
Reference in New Issue
Block a user