Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

char: xillybus: replace usage of found with dedicated list iterator variable

Browse Source 
To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Acked-by: Eli Billauer <eli.billauer@gmail.com>
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220324070939.59297-1-jakobkoschel@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jakob Koschel 2022-03-24 08:09:39 +01:00 committed by Greg Kroah-Hartman
parent f61c5c830f
commit 4834f9898c
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/char/xillybus/xillybus_class.c
View File

@ -174,18 +174,17 @@ void xillybus_cleanup_chrdev(void *private_data,
struct device *dev) struct device *dev)
{ {
int minor; int minor;
struct xilly_unit *unit; struct xilly_unit *unit = NULL, *iter;
bool found = false;
mutex_lock(&unit_mutex); mutex_lock(&unit_mutex);
list_for_each_entry(unit, &unit_list, list_entry) list_for_each_entry(iter, &unit_list, list_entry)
if (unit->private_data == private_data) { if (iter->private_data == private_data) {
found = true; unit = iter;
break; break;
} }
if (!found) { if (!unit) {
dev_err(dev, "Weird bug: Failed to find unit\n"); dev_err(dev, "Weird bug: Failed to find unit\n");
mutex_unlock(&unit_mutex); mutex_unlock(&unit_mutex);
return; return;
@ -216,22 +215,21 @@ int xillybus_find_inode(struct inode *inode,
{ {
int minor = iminor(inode); int minor = iminor(inode);
int major = imajor(inode); int major = imajor(inode);
struct xilly_unit *unit; struct xilly_unit *unit = NULL, *iter;
bool found = false;
mutex_lock(&unit_mutex); mutex_lock(&unit_mutex);
list_for_each_entry(unit, &unit_list, list_entry) list_for_each_entry(iter, &unit_list, list_entry)
if (unit->major == major && if (iter->major == major &&
minor >= unit->lowest_minor && minor >= iter->lowest_minor &&
minor < (unit->lowest_minor + unit->num_nodes)) { minor < (iter->lowest_minor + iter->num_nodes)) {
found = true; unit = iter;
break; break;
} }
mutex_unlock(&unit_mutex); mutex_unlock(&unit_mutex);
if (!found) if (!unit)
return -ENODEV; return -ENODEV;
*private_data = unit->private_data; *private_data = unit->private_data;