Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 14:11:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

x86/sme: Move early SME kernel encryption handling into .head.text

Browse Source 
The .head.text section is the initial primary entrypoint of the core
kernel, and is entered with the CPU executing from a 1:1 mapping of
memory. Such code must never access global variables using absolute
references, as these are based on the kernel virtual mapping which is
not active yet at this point.

Given that the SME startup code is also called from this early execution
context, move it into .head.text as well. This will allow more thorough
build time checks in the future to ensure that early startup code only
uses RIP-relative references to global variables.

Also replace some occurrences of __pa_symbol() [which relies on the
compiler generating an absolute reference, which is not guaranteed] and
an open coded RIP-relative access with RIP_REL_REF().

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Tested-by: Tom Lendacky <thomas.lendacky@amd.com>
Link: https://lore.kernel.org/r/20240227151907.387873-18-ardb+git@google.com
This commit is contained in:
Ard Biesheuvel 2024-02-27 16:19:15 +01:00 committed by Borislav Petkov (AMD)
parent cd0d9d92c8
commit 48204aba80
2 changed files with 21 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
arch/x86/include/asm/mem_encrypt.h
View File

@ -47,8 +47,8 @@ void __init sme_unmap_bootdata(char *real_mode_data);
void __init sme_early_init(void); void __init sme_early_init(void);
void __init sme_encrypt_kernel(struct boot_params *bp); void sme_encrypt_kernel(struct boot_params *bp);
void __init sme_enable(struct boot_params *bp); void sme_enable(struct boot_params *bp);
int __init early_set_memory_decrypted(unsigned long vaddr, unsigned long size); int __init early_set_memory_decrypted(unsigned long vaddr, unsigned long size);
int __init early_set_memory_encrypted(unsigned long vaddr, unsigned long size); int __init early_set_memory_encrypted(unsigned long vaddr, unsigned long size);
@ -81,8 +81,8 @@ static inline void __init sme_unmap_bootdata(char *real_mode_data) { }
static inline void __init sme_early_init(void) { } static inline void __init sme_early_init(void) { }
static inline void __init sme_encrypt_kernel(struct boot_params *bp) { } static inline void sme_encrypt_kernel(struct boot_params *bp) { }
static inline void __init sme_enable(struct boot_params *bp) { } static inline void sme_enable(struct boot_params *bp) { }
static inline void sev_es_init_vc_handling(void) { } static inline void sev_es_init_vc_handling(void) { }

42
arch/x86/mm/mem_encrypt_identity.c
View File

@ -41,6 +41,7 @@
#include <linux/mem_encrypt.h> #include <linux/mem_encrypt.h>
#include <linux/cc_platform.h> #include <linux/cc_platform.h>
#include <asm/init.h>
#include <asm/setup.h> #include <asm/setup.h>
#include <asm/sections.h> #include <asm/sections.h>
#include <asm/coco.h> #include <asm/coco.h>
@ -94,7 +95,7 @@ struct sme_populate_pgd_data {
*/ */
static char sme_workarea[2 * PMD_SIZE] __section(".init.scratch"); static char sme_workarea[2 * PMD_SIZE] __section(".init.scratch");
static void __init sme_clear_pgd(struct sme_populate_pgd_data *ppd) static void __head sme_clear_pgd(struct sme_populate_pgd_data *ppd)
{ {
unsigned long pgd_start, pgd_end, pgd_size; unsigned long pgd_start, pgd_end, pgd_size;
pgd_t *pgd_p; pgd_t *pgd_p;
@ -109,7 +110,7 @@ static void __init sme_clear_pgd(struct sme_populate_pgd_data *ppd)
memset(pgd_p, 0, pgd_size); memset(pgd_p, 0, pgd_size);
} }
static pud_t __init *sme_prepare_pgd(struct sme_populate_pgd_data *ppd) static pud_t __head *sme_prepare_pgd(struct sme_populate_pgd_data *ppd)
{ {
pgd_t *pgd; pgd_t *pgd;
p4d_t *p4d; p4d_t *p4d;
@ -146,7 +147,7 @@ static pud_t __init *sme_prepare_pgd(struct sme_populate_pgd_data *ppd)
return pud; return pud;
} }
static void __init sme_populate_pgd_large(struct sme_populate_pgd_data *ppd) static void __head sme_populate_pgd_large(struct sme_populate_pgd_data *ppd)
{ {
pud_t *pud; pud_t *pud;
pmd_t *pmd; pmd_t *pmd;
@ -162,7 +163,7 @@ static void __init sme_populate_pgd_large(struct sme_populate_pgd_data *ppd)
set_pmd(pmd, __pmd(ppd->paddr | ppd->pmd_flags)); set_pmd(pmd, __pmd(ppd->paddr | ppd->pmd_flags));
} }
static void __init sme_populate_pgd(struct sme_populate_pgd_data *ppd) static void __head sme_populate_pgd(struct sme_populate_pgd_data *ppd)
{ {
pud_t *pud; pud_t *pud;
pmd_t *pmd; pmd_t *pmd;
@ -188,7 +189,7 @@ static void __init sme_populate_pgd(struct sme_populate_pgd_data *ppd)
set_pte(pte, __pte(ppd->paddr | ppd->pte_flags)); set_pte(pte, __pte(ppd->paddr | ppd->pte_flags));
} }
static void __init __sme_map_range_pmd(struct sme_populate_pgd_data *ppd) static void __head __sme_map_range_pmd(struct sme_populate_pgd_data *ppd)
{ {
while (ppd->vaddr < ppd->vaddr_end) { while (ppd->vaddr < ppd->vaddr_end) {
sme_populate_pgd_large(ppd); sme_populate_pgd_large(ppd);
@ -198,7 +199,7 @@ static void __init __sme_map_range_pmd(struct sme_populate_pgd_data *ppd)
} }
} }
static void __init __sme_map_range_pte(struct sme_populate_pgd_data *ppd) static void __head __sme_map_range_pte(struct sme_populate_pgd_data *ppd)
{ {
while (ppd->vaddr < ppd->vaddr_end) { while (ppd->vaddr < ppd->vaddr_end) {
sme_populate_pgd(ppd); sme_populate_pgd(ppd);
@ -208,7 +209,7 @@ static void __init __sme_map_range_pte(struct sme_populate_pgd_data *ppd)
} }
} }
static void __init __sme_map_range(struct sme_populate_pgd_data *ppd, static void __head __sme_map_range(struct sme_populate_pgd_data *ppd,
pmdval_t pmd_flags, pteval_t pte_flags) pmdval_t pmd_flags, pteval_t pte_flags)
{ {
unsigned long vaddr_end; unsigned long vaddr_end;
@ -232,22 +233,22 @@ static void __init __sme_map_range(struct sme_populate_pgd_data *ppd,
__sme_map_range_pte(ppd); __sme_map_range_pte(ppd);
} }
static void __init sme_map_range_encrypted(struct sme_populate_pgd_data *ppd) static void __head sme_map_range_encrypted(struct sme_populate_pgd_data *ppd)
{ {
__sme_map_range(ppd, PMD_FLAGS_ENC, PTE_FLAGS_ENC); __sme_map_range(ppd, PMD_FLAGS_ENC, PTE_FLAGS_ENC);
} }
static void __init sme_map_range_decrypted(struct sme_populate_pgd_data *ppd) static void __head sme_map_range_decrypted(struct sme_populate_pgd_data *ppd)
{ {
__sme_map_range(ppd, PMD_FLAGS_DEC, PTE_FLAGS_DEC); __sme_map_range(ppd, PMD_FLAGS_DEC, PTE_FLAGS_DEC);
} }
static void __init sme_map_range_decrypted_wp(struct sme_populate_pgd_data *ppd) static void __head sme_map_range_decrypted_wp(struct sme_populate_pgd_data *ppd)
{ {
__sme_map_range(ppd, PMD_FLAGS_DEC_WP, PTE_FLAGS_DEC_WP); __sme_map_range(ppd, PMD_FLAGS_DEC_WP, PTE_FLAGS_DEC_WP);
} }
static unsigned long __init sme_pgtable_calc(unsigned long len) static unsigned long __head sme_pgtable_calc(unsigned long len)
{ {
unsigned long entries = 0, tables = 0; unsigned long entries = 0, tables = 0;
@ -284,7 +285,7 @@ static unsigned long __init sme_pgtable_calc(unsigned long len)
return entries + tables; return entries + tables;
} }
void __init sme_encrypt_kernel(struct boot_params *bp) void __head sme_encrypt_kernel(struct boot_params *bp)
{ {
unsigned long workarea_start, workarea_end, workarea_len; unsigned long workarea_start, workarea_end, workarea_len;
unsigned long execute_start, execute_end, execute_len; unsigned long execute_start, execute_end, execute_len;
@ -319,9 +320,8 @@ void __init sme_encrypt_kernel(struct boot_params *bp)
* memory from being cached. * memory from being cached.
*/ */
/* Physical addresses gives us the identity mapped virtual addresses */ kernel_start = (unsigned long)RIP_REL_REF(_text);
kernel_start = __pa_symbol(_text); kernel_end = ALIGN((unsigned long)RIP_REL_REF(_end), PMD_SIZE);
kernel_end = ALIGN(__pa_symbol(_end), PMD_SIZE);
kernel_len = kernel_end - kernel_start; kernel_len = kernel_end - kernel_start;
initrd_start = 0; initrd_start = 0;
@ -338,14 +338,6 @@ void __init sme_encrypt_kernel(struct boot_params *bp)
} }
#endif #endif
/*
* We're running identity mapped, so we must obtain the address to the
* SME encryption workarea using rip-relative addressing.
*/
asm ("lea sme_workarea(%%rip), %0"
: "=r" (workarea_start)
: "p" (sme_workarea));
/* /*
* Calculate required number of workarea bytes needed: * Calculate required number of workarea bytes needed:
* executable encryption area size: * executable encryption area size:
@ -355,7 +347,7 @@ void __init sme_encrypt_kernel(struct boot_params *bp)
* pagetable structures for the encryption of the kernel * pagetable structures for the encryption of the kernel
* pagetable structures for workarea (in case not currently mapped) * pagetable structures for workarea (in case not currently mapped)
*/ */
execute_start = workarea_start; execute_start = workarea_start = (unsigned long)RIP_REL_REF(sme_workarea);
execute_end = execute_start + (PAGE_SIZE * 2) + PMD_SIZE; execute_end = execute_start + (PAGE_SIZE * 2) + PMD_SIZE;
execute_len = execute_end - execute_start; execute_len = execute_end - execute_start;
@ -498,7 +490,7 @@ void __init sme_encrypt_kernel(struct boot_params *bp)
native_write_cr3(__native_read_cr3()); native_write_cr3(__native_read_cr3());
} }
void __init sme_enable(struct boot_params *bp) void __head sme_enable(struct boot_params *bp)
{ {
unsigned int eax, ebx, ecx, edx; unsigned int eax, ebx, ecx, edx;
unsigned long feature_mask; unsigned long feature_mask;