mirror of
https://github.com/torvalds/linux.git
synced 2024-09-20 23:13:00 +00:00
iio: dac: dpot-dac: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230919174931.1417681-30-u.kleine-koenig@pengutronix.de Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
parent
aec6dbe61f
commit
3de9b07295
|
@ -226,15 +226,13 @@ disable_reg:
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int dpot_dac_remove(struct platform_device *pdev)
|
||||
static void dpot_dac_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
|
||||
struct dpot_dac *dac = iio_priv(indio_dev);
|
||||
|
||||
iio_device_unregister(indio_dev);
|
||||
regulator_disable(dac->vref);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id dpot_dac_match[] = {
|
||||
|
@ -245,7 +243,7 @@ MODULE_DEVICE_TABLE(of, dpot_dac_match);
|
|||
|
||||
static struct platform_driver dpot_dac_driver = {
|
||||
.probe = dpot_dac_probe,
|
||||
.remove = dpot_dac_remove,
|
||||
.remove_new = dpot_dac_remove,
|
||||
.driver = {
|
||||
.name = "iio-dpot-dac",
|
||||
.of_match_table = dpot_dac_match,
|
||||
|
|
Loading…
Reference in New Issue
Block a user