Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 06:31:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

scsi: target: core: Flush submission work during TMR processing

Browse Source 
If a cmd is on the submission workqueue then the TMR code will miss it, and
end up returning task not found or success for LUN resets. The fabric
driver might then tell the initiator that the running cmds have been
handled when they are about to run.

This adds a flush when we are processing TMRs to make sure queued cmds do
not run after returning the TMR response.

Link: https://lore.kernel.org/r/20210227170006.5077-25-michael.christie@oracle.com
Tested-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Bodo Stroesser <bostroesser@gmail.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Mike Christie 2021-02-27 11:00:05 -06:00 committed by Martin K. Petersen
parent 6888da8179
commit 3d75948b83
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/target/target_core_tmr.c
View File

@ -124,6 +124,8 @@ void core_tmr_abort_task(
int i; int i;
for (i = 0; i < dev->queue_cnt; i++) { for (i = 0; i < dev->queue_cnt; i++) {
flush_work(&dev->queues[i].sq.work);
spin_lock_irqsave(&dev->queues[i].lock, flags); spin_lock_irqsave(&dev->queues[i].lock, flags);
list_for_each_entry_safe(se_cmd, next, &dev->queues[i].state_list, list_for_each_entry_safe(se_cmd, next, &dev->queues[i].state_list,
state_list) { state_list) {
@ -302,6 +304,8 @@ static void core_tmr_drain_state_list(
* in the Control Mode Page. * in the Control Mode Page.
*/ */
for (i = 0; i < dev->queue_cnt; i++) { for (i = 0; i < dev->queue_cnt; i++) {
flush_work(&dev->queues[i].sq.work);
spin_lock_irqsave(&dev->queues[i].lock, flags); spin_lock_irqsave(&dev->queues[i].lock, flags);
list_for_each_entry_safe(cmd, next, &dev->queues[i].state_list, list_for_each_entry_safe(cmd, next, &dev->queues[i].state_list,
state_list) { state_list) {