Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 14:11:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

remoteproc: k3-r5: Do not allow core1 to power up before core0 via sysfs

Browse Source 
PSC controller has a limitation that it can only power-up the second
core when the first core is in ON state. Power-state for core0 should be
equal to or higher than core1.

Therefore, prevent core1 from powering up before core0 during the start
process from sysfs. Similarly, prevent core0 from shutting down before
core1 has been shut down from sysfs.

Fixes: 6dedbd1d54 ("remoteproc: k3-r5: Add a remoteproc driver for R5F subsystem")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240430105307.1190615-3-b-padhi@ti.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
This commit is contained in:
Beleswar Padhi 2024-04-30 16:23:07 +05:30 committed by Mathieu Poirier
parent 61f6f68447
commit 3c8a9066d5
1 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/remoteproc/ti_k3_r5_remoteproc.c
View File

@ -548,7 +548,7 @@ static int k3_r5_rproc_start(struct rproc *rproc)
struct k3_r5_rproc *kproc = rproc->priv; struct k3_r5_rproc *kproc = rproc->priv;
struct k3_r5_cluster *cluster = kproc->cluster; struct k3_r5_cluster *cluster = kproc->cluster;
struct device *dev = kproc->dev; struct device *dev = kproc->dev;
struct k3_r5_core *core; struct k3_r5_core *core0, *core;
u32 boot_addr; u32 boot_addr;
int ret; int ret;
@ -574,6 +574,15 @@ static int k3_r5_rproc_start(struct rproc *rproc)
goto unroll_core_run; goto unroll_core_run;
} }
} else { } else {
/* do not allow core 1 to start before core 0 */
core0 = list_first_entry(&cluster->cores, struct k3_r5_core,
elem);
if (core != core0 && core0->rproc->state == RPROC_OFFLINE) {
dev_err(dev, "%s: can not start core 1 before core 0\n",
__func__);
return -EPERM;
}
ret = k3_r5_core_run(core); ret = k3_r5_core_run(core);
if (ret) if (ret)
goto put_mbox; goto put_mbox;
@ -619,7 +628,8 @@ static int k3_r5_rproc_stop(struct rproc *rproc)
{ {
struct k3_r5_rproc *kproc = rproc->priv; struct k3_r5_rproc *kproc = rproc->priv;
struct k3_r5_cluster *cluster = kproc->cluster; struct k3_r5_cluster *cluster = kproc->cluster;
struct k3_r5_core *core = kproc->core; struct device *dev = kproc->dev;
struct k3_r5_core *core1, *core = kproc->core;
int ret; int ret;
/* halt all applicable cores */ /* halt all applicable cores */
@ -632,6 +642,15 @@ static int k3_r5_rproc_stop(struct rproc *rproc)
} }
} }
} else { } else {
/* do not allow core 0 to stop before core 1 */
core1 = list_last_entry(&cluster->cores, struct k3_r5_core,
elem);
if (core != core1 && core1->rproc->state != RPROC_OFFLINE) {
dev_err(dev, "%s: can not stop core 0 before core 1\n",
__func__);
return -EPERM;
}
ret = k3_r5_core_halt(core); ret = k3_r5_core_halt(core);
if (ret) if (ret)
goto out; goto out;