Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-28 22:02:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

KVM: Documentation: Update fast page fault for indirect sp

Browse Source 
Clarify locking.rst to mention early that we're not enabling fast page
fault for indirect sps.  The previous wording is confusing, in that it
seems the proposed solution has been already implemented but it has not.

Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Peter Xu 2020-03-05 10:57:08 -05:00 committed by Paolo Bonzini
parent 78f2145c4d
commit 3ac40c404c
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Documentation/virt/kvm/locking.rst
View File

@ -96,19 +96,18 @@ will happen:
We dirty-log for gfn1, that means gfn2 is lost in dirty-bitmap. We dirty-log for gfn1, that means gfn2 is lost in dirty-bitmap.
For direct sp, we can easily avoid it since the spte of direct sp is fixed For direct sp, we can easily avoid it since the spte of direct sp is fixed
to gfn. For indirect sp, before we do cmpxchg, we call gfn_to_pfn_atomic() to gfn. For indirect sp, we disabled fast page fault for simplicity.
to pin gfn to pfn, because after gfn_to_pfn_atomic():
A solution for indirect sp could be to pin the gfn, for example via
kvm_vcpu_gfn_to_pfn_atomic, before the cmpxchg. After the pinning:
- We have held the refcount of pfn that means the pfn can not be freed and - We have held the refcount of pfn that means the pfn can not be freed and
be reused for another gfn. be reused for another gfn.
- The pfn is writable that means it can not be shared between different gfns - The pfn is writable and therefore it cannot be shared between different gfns
by KSM. by KSM.
Then, we can ensure the dirty bitmaps is correctly set for a gfn. Then, we can ensure the dirty bitmaps is correctly set for a gfn.
Currently, to simplify the whole things, we disable fast page fault for
indirect shadow page.
2) Dirty bit tracking 2) Dirty bit tracking
In the origin code, the spte can be fast updated (non-atomically) if the In the origin code, the spte can be fast updated (non-atomically) if the