Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-27 05:11:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

freezer: use lock_task_sighand() in fake_signal_wake_up()

Browse Source 
cgroup_freezer calls freeze_task() without holding tasklist_lock and,
if the task is exiting, its ->sighand may be gone by the time
fake_signal_wake_up() is called.  Use lock_task_sighand() instead of
accessing ->sighand directly.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Paul Menage <paul@paulmenage.org>
This commit is contained in:
Tejun Heo 2011-11-21 12:32:26 -08:00
parent 5ece3eae4c
commit 37ad8aca94
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/freezer.c
View File

@ -93,9 +93,10 @@ static void fake_signal_wake_up(struct task_struct *p)
{ {
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&p->sighand->siglock, flags); if (lock_task_sighand(p, &flags)) {
signal_wake_up(p, 0); signal_wake_up(p, 0);
spin_unlock_irqrestore(&p->sighand->siglock, flags); unlock_task_sighand(p, &flags);
}
} }
/** /**