Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 14:42:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

pNFS/flexfiles: Simplify allocation of the mirror array

Browse Source 
Just allocate the array at the end of the layout segment structure,
instead of allocating it as a separate array of pointers.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
This commit is contained in:
Trond Myklebust 2020-03-19 10:13:05 -04:00
parent df513a7711
commit 329651b1f1
2 changed files with 6 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
fs/nfs/flexfilelayout/flexfilelayout.c
View File

@ -248,18 +248,10 @@ static void ff_layout_put_mirror(struct nfs4_ff_layout_mirror *mirror)
static void ff_layout_free_mirror_array(struct nfs4_ff_layout_segment *fls) static void ff_layout_free_mirror_array(struct nfs4_ff_layout_segment *fls)
{ {
int i; u32 i;
if (fls->mirror_array) { for (i = 0; i < fls->mirror_array_cnt; i++)
for (i = 0; i < fls->mirror_array_cnt; i++) { ff_layout_put_mirror(fls->mirror_array[i]);
/* normally mirror_ds is freed in
* .free_deviceid_node but we still do it here
* for .alloc_lseg error path */
ff_layout_put_mirror(fls->mirror_array[i]);
}
kfree(fls->mirror_array);
fls->mirror_array = NULL;
}
} }
static int ff_layout_check_layout(struct nfs4_layoutget_res *lgr) static int ff_layout_check_layout(struct nfs4_layoutget_res *lgr)
@ -400,16 +392,13 @@ ff_layout_alloc_lseg(struct pnfs_layout_hdr *lh,
goto out_err_free; goto out_err_free;
rc = -ENOMEM; rc = -ENOMEM;
fls = kzalloc(sizeof(*fls), gfp_flags); fls = kzalloc(struct_size(fls, mirror_array, mirror_array_cnt),
gfp_flags);
if (!fls) if (!fls)
goto out_err_free; goto out_err_free;
fls->mirror_array_cnt = mirror_array_cnt; fls->mirror_array_cnt = mirror_array_cnt;
fls->stripe_unit = stripe_unit; fls->stripe_unit = stripe_unit;
fls->mirror_array = kcalloc(fls->mirror_array_cnt,
sizeof(fls->mirror_array[0]), gfp_flags);
if (fls->mirror_array == NULL)
goto out_err_free;
for (i = 0; i < fls->mirror_array_cnt; i++) { for (i = 0; i < fls->mirror_array_cnt; i++) {
struct nfs4_ff_layout_mirror *mirror; struct nfs4_ff_layout_mirror *mirror;

2
fs/nfs/flexfilelayout/flexfilelayout.h
View File

@ -99,7 +99,7 @@ struct nfs4_ff_layout_segment {
u64 stripe_unit; u64 stripe_unit;
u32 flags; u32 flags;
u32 mirror_array_cnt; u32 mirror_array_cnt;
struct nfs4_ff_layout_mirror **mirror_array; struct nfs4_ff_layout_mirror *mirror_array[];
}; };
struct nfs4_flexfile_layout { struct nfs4_flexfile_layout {