Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

target: Fix incorrect fallthrough of ALUA Standby/Offline/Transition CDBs

Browse Source 
This patch fixes a bug where a handful of informational / control CDBs
that should be allowed during ALUA access state Standby/Offline/Transition
where incorrectly returning CHECK_CONDITION + ASCQ_04H_ALUA_TG_PT_*.

This includes INQUIRY + REPORT_LUNS, which would end up preventing LUN
registration when LUN scanning occured during these ALUA access states.

Cc: Hannes Reinecke <hare@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Nicholas Bellinger 2013-04-10 15:00:27 -07:00
parent 055f648c49
commit 30f359a6f9
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/target/target_core_alua.c
View File

@ -409,6 +409,7 @@ static inline int core_alua_state_standby(
case REPORT_LUNS: case REPORT_LUNS:
case RECEIVE_DIAGNOSTIC: case RECEIVE_DIAGNOSTIC:
case SEND_DIAGNOSTIC: case SEND_DIAGNOSTIC:
return 0;
case MAINTENANCE_IN: case MAINTENANCE_IN:
switch (cdb[1] & 0x1f) { switch (cdb[1] & 0x1f) {
case MI_REPORT_TARGET_PGS: case MI_REPORT_TARGET_PGS:
@ -451,6 +452,7 @@ static inline int core_alua_state_unavailable(
switch (cdb[0]) { switch (cdb[0]) {
case INQUIRY: case INQUIRY:
case REPORT_LUNS: case REPORT_LUNS:
return 0;
case MAINTENANCE_IN: case MAINTENANCE_IN:
switch (cdb[1] & 0x1f) { switch (cdb[1] & 0x1f) {
case MI_REPORT_TARGET_PGS: case MI_REPORT_TARGET_PGS:
@ -491,6 +493,7 @@ static inline int core_alua_state_transition(
switch (cdb[0]) { switch (cdb[0]) {
case INQUIRY: case INQUIRY:
case REPORT_LUNS: case REPORT_LUNS:
return 0;
case MAINTENANCE_IN: case MAINTENANCE_IN:
switch (cdb[1] & 0x1f) { switch (cdb[1] & 0x1f) {
case MI_REPORT_TARGET_PGS: case MI_REPORT_TARGET_PGS: