Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-15 00:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

bcache: properly initialize 'path' and 'err' in register_bcache()

Browse Source 
Patch "bcache: rework error unwinding in register_bcache" from
Christoph Hellwig changes the local variables 'path' and 'err'
in undefined initial state. If the code in register_bcache() jumps
to label 'out:' or 'out_module_put:' by goto, these two variables
might be reference with undefined value by the following line,

	out_module_put:
	        module_put(THIS_MODULE);
	out:
	        pr_info("error %s: %s", path, err);
	        return ret;

Therefore this patch initializes these two local variables properly
in register_bcache() to avoid such issue.

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Coly Li 2020-01-24 01:01:29 +08:00 committed by Jens Axboe
parent 50246693f8
commit 29cda393bc
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/md/bcache/super.c
View File

@ -2376,18 +2376,20 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr,
const char *buffer, size_t size) const char *buffer, size_t size)
{ {
const char *err; const char *err;
char *path; char *path = NULL;
struct cache_sb *sb; struct cache_sb *sb;
struct block_device *bdev = NULL; struct block_device *bdev = NULL;
struct page *sb_page; struct page *sb_page;
ssize_t ret; ssize_t ret;
ret = -EBUSY; ret = -EBUSY;
err = "failed to reference bcache module";
if (!try_module_get(THIS_MODULE)) if (!try_module_get(THIS_MODULE))
goto out; goto out;
/* For latest state of bcache_is_reboot */ /* For latest state of bcache_is_reboot */
smp_mb(); smp_mb();
err = "bcache is in reboot";
if (bcache_is_reboot) if (bcache_is_reboot)
goto out_module_put; goto out_module_put;