Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

clk: fixed-factor: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-9-u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-12 17:14:50 +01:00 committed by Stephen Boyd
parent 1920aa93a8
commit 27237f4b37
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/clk/clk-fixed-factor.c
View File

@ -297,14 +297,12 @@ void __init of_fixed_factor_clk_setup(struct device_node *node)
CLK_OF_DECLARE(fixed_factor_clk, "fixed-factor-clock", CLK_OF_DECLARE(fixed_factor_clk, "fixed-factor-clock",
of_fixed_factor_clk_setup); of_fixed_factor_clk_setup);
static int of_fixed_factor_clk_remove(struct platform_device *pdev) static void of_fixed_factor_clk_remove(struct platform_device *pdev)
{ {
struct clk_hw *clk = platform_get_drvdata(pdev); struct clk_hw *clk = platform_get_drvdata(pdev);
of_clk_del_provider(pdev->dev.of_node); of_clk_del_provider(pdev->dev.of_node);
clk_hw_unregister_fixed_factor(clk); clk_hw_unregister_fixed_factor(clk);
return 0;
} }
static int of_fixed_factor_clk_probe(struct platform_device *pdev) static int of_fixed_factor_clk_probe(struct platform_device *pdev)
@ -336,7 +334,7 @@ static struct platform_driver of_fixed_factor_clk_driver = {
.of_match_table = of_fixed_factor_clk_ids, .of_match_table = of_fixed_factor_clk_ids,
}, },
.probe = of_fixed_factor_clk_probe, .probe = of_fixed_factor_clk_probe,
.remove = of_fixed_factor_clk_remove, .remove_new = of_fixed_factor_clk_remove,
}; };
builtin_platform_driver(of_fixed_factor_clk_driver); builtin_platform_driver(of_fixed_factor_clk_driver);
#endif #endif