Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: ethernet: moxa:: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Uwe Kleine-König 2023-09-18 22:42:06 +02:00 committed by David S. Miller
parent 5253ae3a62
commit 253f9c4727
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ethernet/moxa/moxart_ether.c
View File

@ -558,7 +558,7 @@ irq_map_fail:
return ret; return ret;
} }
static int moxart_remove(struct platform_device *pdev) static void moxart_remove(struct platform_device *pdev)
{ {
struct net_device *ndev = platform_get_drvdata(pdev); struct net_device *ndev = platform_get_drvdata(pdev);
@ -566,8 +566,6 @@ static int moxart_remove(struct platform_device *pdev)
devm_free_irq(&pdev->dev, ndev->irq, ndev); devm_free_irq(&pdev->dev, ndev->irq, ndev);
moxart_mac_free_memory(ndev); moxart_mac_free_memory(ndev);
free_netdev(ndev); free_netdev(ndev);
return 0;
} }
static const struct of_device_id moxart_mac_match[] = { static const struct of_device_id moxart_mac_match[] = {
@ -578,7 +576,7 @@ MODULE_DEVICE_TABLE(of, moxart_mac_match);
static struct platform_driver moxart_mac_driver = { static struct platform_driver moxart_mac_driver = {
.probe = moxart_mac_probe, .probe = moxart_mac_probe,
.remove = moxart_remove, .remove_new = moxart_remove,
.driver = { .driver = {
.name = "moxart-ethernet", .name = "moxart-ethernet",
.of_match_table = moxart_mac_match, .of_match_table = moxart_mac_match,