Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 06:01:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib/strn*,objtool: Enforce user_access_begin() rules

Browse Source 
Apparently GCC can fail to inline a 'static inline' single caller
function:

  lib/strnlen_user.o: warning: objtool: strnlen_user()+0x33: call to do_strnlen_user() with UACCESS enabled
  lib/strncpy_from_user.o: warning: objtool: strncpy_from_user()+0x33: call to do_strncpy_from_user() with UACCESS enabled

Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lore.kernel.org/r/20220408094718.262932488@infradead.org
This commit is contained in:
Peter Zijlstra 2022-04-08 11:45:53 +02:00
parent 610abf3dea
commit 226d44acf6
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/strncpy_from_user.c
View File

@ -25,7 +25,7 @@
* hit it), 'max' is the address space maximum (and we return * hit it), 'max' is the address space maximum (and we return
* -EFAULT if we hit it). * -EFAULT if we hit it).
*/ */
static inline long do_strncpy_from_user(char *dst, const char __user *src, static __always_inline long do_strncpy_from_user(char *dst, const char __user *src,
unsigned long count, unsigned long max) unsigned long count, unsigned long max)
{ {
const struct word_at_a_time constants = WORD_AT_A_TIME_CONSTANTS; const struct word_at_a_time constants = WORD_AT_A_TIME_CONSTANTS;

2
lib/strnlen_user.c
View File

@ -20,7 +20,7 @@
* if it fits in a aligned 'long'. The caller needs to check * if it fits in a aligned 'long'. The caller needs to check
* the return value against "> max". * the return value against "> max".
*/ */
static inline long do_strnlen_user(const char __user *src, unsigned long count, unsigned long max) static __always_inline long do_strnlen_user(const char __user *src, unsigned long count, unsigned long max)
{ {
const struct word_at_a_time constants = WORD_AT_A_TIME_CONSTANTS; const struct word_at_a_time constants = WORD_AT_A_TIME_CONSTANTS;
unsigned long align, res = 0; unsigned long align, res = 0;