Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

alpha: get rid of pointless insn in ret_from_kernel_thread

Browse Source 
It used to clear a3, so that signal handling on
return to userland would've passed zero r0 to do_work_pending(),
preventing the syscall restart logics from triggering.

	It had been pointless all along, since we only go there
after successful do_execve().  Which does clear regs->r0 on alpha,
preventing the syscall restart logics just fine, no extra help
needed.  Good thing, that, since back in 2012 do_work_pending()
has lost the second argument, shifting the registers used to pass
that thing from a3 to a2.  Commit that had done that adjusted the
entry.S code accordingly, but missed that one.

	As the result, we were left with useless insn in
ret_from_kernel_thread and confusing comment to go with it.
Get rid of both...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2018-03-19 14:29:17 -04:00
parent e4eacd6b89
commit 206b1c6012
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
arch/alpha/kernel/entry.S
View File

@ -785,7 +785,6 @@ ret_from_kernel_thread:
mov $9, $27
mov $10, $16
jsr $26, ($9)
mov $31, $19 /* to disable syscall restarts */
br $31, ret_to_user
.end ret_from_kernel_thread