Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 22:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

tcm_fc: Avoid debug overhead when not debugging

Browse Source 
Stop doing a pile of work related to debugging messages when
the ft_debug_logging flag is not set. Use unlikely to add the
check in a way that the check can be inlined without inlining the
whole thing.

Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Mark Rustad 2012-08-01 14:51:53 -07:00 committed by Nicholas Bellinger
parent 101998f6fc
commit 1fa8f45041
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/target/tcm_fc/tcm_fc.h
View File

@ -131,6 +131,7 @@ extern struct list_head ft_lport_list;
extern struct mutex ft_lport_lock; extern struct mutex ft_lport_lock;
extern struct fc4_prov ft_prov; extern struct fc4_prov ft_prov;
extern struct target_fabric_configfs *ft_configfs; extern struct target_fabric_configfs *ft_configfs;
extern unsigned int ft_debug_logging;
/* /*
* Fabric methods. * Fabric methods.

8
drivers/target/tcm_fc/tfc_cmd.c
View File

@ -48,7 +48,7 @@
/* /*
* Dump cmd state for debugging. * Dump cmd state for debugging.
*/ */
void ft_dump_cmd(struct ft_cmd *cmd, const char *caller) static void _ft_dump_cmd(struct ft_cmd *cmd, const char *caller)
{ {
struct fc_exch *ep; struct fc_exch *ep;
struct fc_seq *sp; struct fc_seq *sp;
@ -80,6 +80,12 @@ void ft_dump_cmd(struct ft_cmd *cmd, const char *caller)
} }
} }
void ft_dump_cmd(struct ft_cmd *cmd, const char *caller)
{
if (unlikely(ft_debug_logging))
_ft_dump_cmd(cmd, caller);
}
static void ft_free_cmd(struct ft_cmd *cmd) static void ft_free_cmd(struct ft_cmd *cmd)
{ {
struct fc_frame *fp; struct fc_frame *fp;