mirror of
https://github.com/torvalds/linux.git
synced 2024-11-11 14:42:24 +00:00
i2c: slave eeprom: clean up sysfs bin attribute read()/write()
The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Note, on file size overflow read() now returns 0, and this is a correct and expected EOF notification according to POSIX. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
This commit is contained in:
parent
bc0195aad0
commit
1f023297f7
@ -80,9 +80,6 @@ static ssize_t i2c_slave_eeprom_bin_read(struct file *filp, struct kobject *kobj
|
|||||||
struct eeprom_data *eeprom;
|
struct eeprom_data *eeprom;
|
||||||
unsigned long flags;
|
unsigned long flags;
|
||||||
|
|
||||||
if (off + count > attr->size)
|
|
||||||
return -EFBIG;
|
|
||||||
|
|
||||||
eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj));
|
eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj));
|
||||||
|
|
||||||
spin_lock_irqsave(&eeprom->buffer_lock, flags);
|
spin_lock_irqsave(&eeprom->buffer_lock, flags);
|
||||||
@ -98,9 +95,6 @@ static ssize_t i2c_slave_eeprom_bin_write(struct file *filp, struct kobject *kob
|
|||||||
struct eeprom_data *eeprom;
|
struct eeprom_data *eeprom;
|
||||||
unsigned long flags;
|
unsigned long flags;
|
||||||
|
|
||||||
if (off + count > attr->size)
|
|
||||||
return -EFBIG;
|
|
||||||
|
|
||||||
eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj));
|
eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj));
|
||||||
|
|
||||||
spin_lock_irqsave(&eeprom->buffer_lock, flags);
|
spin_lock_irqsave(&eeprom->buffer_lock, flags);
|
||||||
|
Loading…
Reference in New Issue
Block a user