Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-10 22:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

iio: dac: mcp4725: Add use_ext_ref_voltage to struct mcp4725_chip_info

Browse Source 
The MCP4725 has external voltage reference compared MCP4725 which
has reference embeedded in eeprom. Add use_ext_ref_voltage variable
to struct mcp4725_chip_info to handle this difference.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/20230903115548.59306-4-biju.das.jz@bp.renesas.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Biju Das 2023-09-03 12:55:47 +01:00 committed by Jonathan Cameron
parent 18bdc686c1
commit 155da070b4
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/iio/dac/mcp4725.c
View File

@ -33,6 +33,7 @@
struct mcp4725_chip_info { struct mcp4725_chip_info {
const struct iio_chan_spec *chan_spec; const struct iio_chan_spec *chan_spec;
unsigned int chip_id; unsigned int chip_id;
bool use_ext_ref_voltage;
}; };
struct mcp4725_data { struct mcp4725_data {
@ -416,7 +417,7 @@ static int mcp4725_probe(struct i2c_client *client)
pdata = &pdata_dt; pdata = &pdata_dt;
} }
if (info->chip_id == MCP4725 && pdata->use_vref) { if (info->use_ext_ref_voltage && pdata->use_vref) {
dev_err(&client->dev, dev_err(&client->dev,
"external reference is unavailable on MCP4725"); "external reference is unavailable on MCP4725");
return -EINVAL; return -EINVAL;
@ -472,10 +473,10 @@ static int mcp4725_probe(struct i2c_client *client)
data->powerdown = pd > 0; data->powerdown = pd > 0;
data->powerdown_mode = pd ? pd - 1 : 2; /* largest resistor to gnd */ data->powerdown_mode = pd ? pd - 1 : 2; /* largest resistor to gnd */
data->dac_value = (inbuf[1] << 4) | (inbuf[2] >> 4); data->dac_value = (inbuf[1] << 4) | (inbuf[2] >> 4);
if (info->chip_id == MCP4726) if (!info->use_ext_ref_voltage)
ref = (inbuf[3] >> 3) & 0x3; ref = (inbuf[3] >> 3) & 0x3;
if (info->chip_id == MCP4726 && ref != data->ref_mode) { if (!info->use_ext_ref_voltage && ref != data->ref_mode) {
dev_info(&client->dev, dev_info(&client->dev,
"voltage reference mode differs (conf: %u, eeprom: %u), setting %u", "voltage reference mode differs (conf: %u, eeprom: %u), setting %u",
data->ref_mode, ref, data->ref_mode); data->ref_mode, ref, data->ref_mode);
@ -515,6 +516,7 @@ static void mcp4725_remove(struct i2c_client *client)
static const struct mcp4725_chip_info mcp4725 = { static const struct mcp4725_chip_info mcp4725 = {
.chan_spec = &mcp472x_channel[MCP4725], .chan_spec = &mcp472x_channel[MCP4725],
.chip_id = MCP4725, .chip_id = MCP4725,
.use_ext_ref_voltage = true,
}; };
static const struct mcp4725_chip_info mcp4726 = { static const struct mcp4725_chip_info mcp4726 = {