Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-31 23:31:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

proc/wchan: use printk format instead of lookup_symbol_name()

Browse Source 
To resolve the symbol fuction name for wchan, use the printk format
specifier %ps instead of manually looking up the symbol function name
via lookup_symbol_name().

Link: https://lkml.kernel.org/r/20201217165413.GA1959@ls3530.fritz.box
Signed-off-by: Helge Deller <deller@gmx.de>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Helge Deller 2021-02-25 17:20:45 -08:00 committed by Linus Torvalds
parent 2956f4e4f0
commit 152c432b12
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
fs/proc/base.c
View File

@ -67,7 +67,6 @@
#include <linux/mm.h> #include <linux/mm.h>
#include <linux/swap.h> #include <linux/swap.h>
#include <linux/rcupdate.h> #include <linux/rcupdate.h>
#include <linux/kallsyms.h>
#include <linux/stacktrace.h> #include <linux/stacktrace.h>
#include <linux/resource.h> #include <linux/resource.h>
#include <linux/module.h> #include <linux/module.h>
@ -386,19 +385,17 @@ static int proc_pid_wchan(struct seq_file *m, struct pid_namespace *ns,
struct pid *pid, struct task_struct *task) struct pid *pid, struct task_struct *task)
{ {
unsigned long wchan; unsigned long wchan;
char symname[KSYM_NAME_LEN];
if (!ptrace_may_access(task, PTRACE_MODE_READ_FSCREDS)) if (ptrace_may_access(task, PTRACE_MODE_READ_FSCREDS))
goto print0; wchan = get_wchan(task);
else
wchan = 0;
wchan = get_wchan(task); if (wchan)
if (wchan && !lookup_symbol_name(wchan, symname)) { seq_printf(m, "%ps", (void *) wchan);
seq_puts(m, symname); else
return 0; seq_putc(m, '0');
}
print0:
seq_putc(m, '0');
return 0; return 0;
} }
#endif /* CONFIG_KALLSYMS */ #endif /* CONFIG_KALLSYMS */