Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-28 22:02:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

memory: stm32-fmc2-ebi: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/fa74d4ae3cbf337dcae66db8479125fec8078153.1702822744.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This commit is contained in:
Uwe Kleine-König 2023-12-17 15:29:37 +01:00 committed by Krzysztof Kozlowski
parent 8013408e49
commit 1455b6b0c8
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/memory/stm32-fmc2-ebi.c
View File

@ -1146,7 +1146,7 @@ err_release:
return ret; return ret;
} }
static int stm32_fmc2_ebi_remove(struct platform_device *pdev) static void stm32_fmc2_ebi_remove(struct platform_device *pdev)
{ {
struct stm32_fmc2_ebi *ebi = platform_get_drvdata(pdev); struct stm32_fmc2_ebi *ebi = platform_get_drvdata(pdev);
@ -1154,8 +1154,6 @@ static int stm32_fmc2_ebi_remove(struct platform_device *pdev)
stm32_fmc2_ebi_disable_banks(ebi); stm32_fmc2_ebi_disable_banks(ebi);
stm32_fmc2_ebi_disable(ebi); stm32_fmc2_ebi_disable(ebi);
clk_disable_unprepare(ebi->clk); clk_disable_unprepare(ebi->clk);
return 0;
} }
static int __maybe_unused stm32_fmc2_ebi_suspend(struct device *dev) static int __maybe_unused stm32_fmc2_ebi_suspend(struct device *dev)
@ -1197,7 +1195,7 @@ MODULE_DEVICE_TABLE(of, stm32_fmc2_ebi_match);
static struct platform_driver stm32_fmc2_ebi_driver = { static struct platform_driver stm32_fmc2_ebi_driver = {
.probe = stm32_fmc2_ebi_probe, .probe = stm32_fmc2_ebi_probe,
.remove = stm32_fmc2_ebi_remove, .remove_new = stm32_fmc2_ebi_remove,
.driver = { .driver = {
.name = "stm32_fmc2_ebi", .name = "stm32_fmc2_ebi",
.of_match_table = stm32_fmc2_ebi_match, .of_match_table = stm32_fmc2_ebi_match,