Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-11 22:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel()

Browse Source 
clang warns:

drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
                              (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
                               ~~~~~~^~~

buf is an array in the middle of a struct so deferencing it is not a
problem as long as ctx is not NULL. Eliminate the check, which fixes the
warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/1398
Link: https://lore.kernel.org/r/20210617063123.21239-1-nathan@kernel.org
Fixes: 580c0255e4 ("scsi: elx: efct: RQ buffer, memory pool allocation and deallocation APIs")
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Nathan Chancellor 2021-06-16 23:31:23 -07:00 committed by Martin K. Petersen
parent a255036178
commit 0d7be7a8a0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/scsi/elx/efct/efct_hw.c
View File

@ -1519,8 +1519,7 @@ efct_hw_command_cancel(struct efct_hw *hw)
struct efct_command_ctx, list_entry); struct efct_command_ctx, list_entry);
efc_log_debug(hw->os, "hung command %08x\n", efc_log_debug(hw->os, "hung command %08x\n",
!ctx ? U32_MAX : !ctx ? U32_MAX : *((u32 *)ctx->buf));
(!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
spin_unlock_irqrestore(&hw->cmd_lock, flags); spin_unlock_irqrestore(&hw->cmd_lock, flags);
rc = efct_hw_command_process(hw, -1, mqe, SLI4_BMBX_SIZE); rc = efct_hw_command_process(hw, -1, mqe, SLI4_BMBX_SIZE);
spin_lock_irqsave(&hw->cmd_lock, flags); spin_lock_irqsave(&hw->cmd_lock, flags);