Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-09-20 06:53:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

mm/kmemleak: replace strncpy() with strscpy()

Browse Source 
Replace the depreciated[1] strncpy() calls with strscpy().  Uses of
object->comm do not depend on the padding side-effect.

Link: https://github.com/KSPP/linux/issues/90 [1]
Link: https://lkml.kernel.org/r/20240710001300.work.004-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Kees Cook 2024-07-09 17:13:08 -07:00 committed by Andrew Morton
parent 53dabce265
commit 0b84780134
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mm/kmemleak.c
View File

@ -657,10 +657,10 @@ static struct kmemleak_object *__alloc_object(gfp_t gfp)
/* task information */ /* task information */
if (in_hardirq()) { if (in_hardirq()) {
object->pid = 0; object->pid = 0;
strncpy(object->comm, "hardirq", sizeof(object->comm)); strscpy(object->comm, "hardirq");
} else if (in_serving_softirq()) { } else if (in_serving_softirq()) {
object->pid = 0; object->pid = 0;
strncpy(object->comm, "softirq", sizeof(object->comm)); strscpy(object->comm, "softirq");
} else { } else {
object->pid = current->pid; object->pid = current->pid;
/* /*
@ -669,7 +669,7 @@ static struct kmemleak_object *__alloc_object(gfp_t gfp)
* dependency issues with current->alloc_lock. In the worst * dependency issues with current->alloc_lock. In the worst
* case, the command line is not correct. * case, the command line is not correct.
*/ */
strncpy(object->comm, current->comm, sizeof(object->comm)); strscpy(object->comm, current->comm);
} }
/* kernel backtrace */ /* kernel backtrace */