mirror of
https://github.com/torvalds/linux.git
synced 2024-11-16 00:52:01 +00:00
[ARM] omap: usb: thou shalt not provide empty release functions
... for devices. Doing so is a bug, plain and simple, and drives GregKH round the bend. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
parent
b7cfc9ca6a
commit
0b23a0efec
@ -431,15 +431,6 @@ bad:
|
||||
|
||||
/*-------------------------------------------------------------------------*/
|
||||
|
||||
#if defined(CONFIG_USB_GADGET_OMAP) || \
|
||||
defined(CONFIG_USB_OHCI_HCD) || defined(CONFIG_USB_OHCI_HCD_MODULE) || \
|
||||
(defined(CONFIG_USB_OTG) && defined(CONFIG_ARCH_OMAP_OTG))
|
||||
static void usb_release(struct device *dev)
|
||||
{
|
||||
/* normally not freed */
|
||||
}
|
||||
#endif
|
||||
|
||||
#ifdef CONFIG_USB_GADGET_OMAP
|
||||
|
||||
static struct resource udc_resources[] = {
|
||||
@ -466,7 +457,6 @@ static struct platform_device udc_device = {
|
||||
.name = "omap_udc",
|
||||
.id = -1,
|
||||
.dev = {
|
||||
.release = usb_release,
|
||||
.dma_mask = &udc_dmamask,
|
||||
.coherent_dma_mask = 0xffffffff,
|
||||
},
|
||||
@ -497,7 +487,6 @@ static struct platform_device ohci_device = {
|
||||
.name = "ohci",
|
||||
.id = -1,
|
||||
.dev = {
|
||||
.release = usb_release,
|
||||
.dma_mask = &ohci_dmamask,
|
||||
.coherent_dma_mask = 0xffffffff,
|
||||
},
|
||||
@ -524,9 +513,6 @@ static struct resource otg_resources[] = {
|
||||
static struct platform_device otg_device = {
|
||||
.name = "omap_otg",
|
||||
.id = -1,
|
||||
.dev = {
|
||||
.release = usb_release,
|
||||
},
|
||||
.num_resources = ARRAY_SIZE(otg_resources),
|
||||
.resource = otg_resources,
|
||||
};
|
||||
|
Loading…
Reference in New Issue
Block a user