Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-27 05:11:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

powerpc/powernv: Move opal_power_control_init() call in opal_init().

Browse Source 
opal_power_control_init() depends on opal message notifier to be
initialized, which is done in opal_init()->opal_message_init(). But both
these initialization are called through machine initcalls and it all
depends on in which order they being called. So far these are called in
correct order (may be we got lucky) and never saw any issue. But it is
clearer to control initialization order explicitly by moving
opal_power_control_init() into opal_init().

Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Mahesh Salgaonkar 2018-12-13 11:17:31 +05:30 committed by Michael Ellerman
parent ae6263cc33
commit 08fb726df1
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
arch/powerpc/include/asm/opal.h
View File

@ -347,6 +347,7 @@ extern int opal_async_comp_init(void);
extern int opal_sensor_init(void);
extern int opal_hmi_handler_init(void);
extern int opal_event_init(void);
int opal_power_control_init(void);
extern int opal_machine_check(struct pt_regs *regs);
extern bool opal_mce_check_early_recovery(struct pt_regs *regs);

3
arch/powerpc/platforms/powernv/opal-power.c
View File

@ -138,7 +138,7 @@ static struct notifier_block opal_power_control_nb = {
.priority = 0,
};
static int __init opal_power_control_init(void)
int __init opal_power_control_init(void)
{
int ret, supported = 0;
struct device_node *np;
@ -176,4 +176,3 @@ static int __init opal_power_control_init(void)
return 0;
}
machine_subsys_initcall(powernv, opal_power_control_init);

3
arch/powerpc/platforms/powernv/opal.c
View File

@ -960,6 +960,9 @@ static int __init opal_init(void)
/* Initialise OPAL sensor groups */
opal_sensor_groups_init();
/* Initialise OPAL Power control interface */
opal_power_control_init();
return 0;
}
machine_subsys_initcall(powernv, opal_init);