Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-18 01:51:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: phy: mdio-boardinfo: Allow recursive mdiobus_register()

Browse Source 
mdiobus_register will search for any mdiobus board info registered for
the bus being registered. If found, it will probe devices on the bus.
That device, if for example it is an ethernet switch, may then try to
register an mdio bus. Thus we need to allow recursive calls to
mdiobus_register.

Holding the mdio_board_lock will cause a deadlock during this
recursion. Release the lock and use list_for_each_entry_safe.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Andrew Lunn 2018-04-19 02:00:47 +02:00 committed by David S. Miller
parent bda73d4ec9
commit 0263ea5cdd
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/phy/mdio-boardinfo.c
View File

@ -30,17 +30,20 @@ void mdiobus_setup_mdiodev_from_board_info(struct mii_bus *bus,
struct mdio_board_info *bi)) struct mdio_board_info *bi))
{ {
struct mdio_board_entry *be; struct mdio_board_entry *be;
struct mdio_board_entry *tmp;
struct mdio_board_info *bi; struct mdio_board_info *bi;
int ret; int ret;
mutex_lock(&mdio_board_lock); mutex_lock(&mdio_board_lock);
list_for_each_entry(be, &mdio_board_list, list) { list_for_each_entry_safe(be, tmp, &mdio_board_list, list) {
bi = &be->board_info; bi = &be->board_info;
if (strcmp(bus->id, bi->bus_id)) if (strcmp(bus->id, bi->bus_id))
continue; continue;
mutex_unlock(&mdio_board_lock);
ret = cb(bus, bi); ret = cb(bus, bi);
mutex_lock(&mdio_board_lock);
if (ret) if (ret)
continue; continue;