2018-06-06 02:42:14 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
2005-11-02 03:58:39 +00:00
|
|
|
* Copyright (c) 2000-2005 Silicon Graphics, Inc.
|
|
|
|
* All Rights Reserved.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
|
|
|
#ifndef __XFS_BUF_H__
|
|
|
|
#define __XFS_BUF_H__
|
|
|
|
|
|
|
|
#include <linux/list.h>
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/spinlock.h>
|
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/fs.h>
|
2015-09-08 21:58:40 +00:00
|
|
|
#include <linux/dax.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/uio.h>
|
2013-08-28 00:18:05 +00:00
|
|
|
#include <linux/list_lru.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2022-07-19 01:20:37 +00:00
|
|
|
extern struct kmem_cache *xfs_buf_cache;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Base types
|
|
|
|
*/
|
2020-06-29 21:48:47 +00:00
|
|
|
struct xfs_buf;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-01-11 04:39:08 +00:00
|
|
|
#define XFS_BUF_DADDR_NULL ((xfs_daddr_t) (-1LL))
|
|
|
|
|
2022-04-20 22:44:59 +00:00
|
|
|
#define XBF_READ (1u << 0) /* buffer intended for reading from device */
|
|
|
|
#define XBF_WRITE (1u << 1) /* buffer intended for writing to device */
|
|
|
|
#define XBF_READ_AHEAD (1u << 2) /* asynchronous read-ahead */
|
|
|
|
#define XBF_NO_IOACCT (1u << 3) /* bypass I/O accounting (non-LRU bufs) */
|
|
|
|
#define XBF_ASYNC (1u << 4) /* initiator will not wait for completion */
|
|
|
|
#define XBF_DONE (1u << 5) /* all pages in the buffer uptodate */
|
|
|
|
#define XBF_STALE (1u << 6) /* buffer has been staled, do not find it */
|
|
|
|
#define XBF_WRITE_FAIL (1u << 7) /* async writes have failed on this buffer */
|
2011-07-08 12:36:32 +00:00
|
|
|
|
2020-06-29 21:48:46 +00:00
|
|
|
/* buffer type flags for write callbacks */
|
2022-04-20 22:44:59 +00:00
|
|
|
#define _XBF_INODES (1u << 16)/* inode buffer */
|
|
|
|
#define _XBF_DQUOTS (1u << 17)/* dquot buffer */
|
|
|
|
#define _XBF_LOGRECOVERY (1u << 18)/* log recovery buffer */
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-06-24 01:49:12 +00:00
|
|
|
/* flags used only internally */
|
2022-04-20 22:44:59 +00:00
|
|
|
#define _XBF_PAGES (1u << 20)/* backed by refcounted pages */
|
|
|
|
#define _XBF_KMEM (1u << 21)/* backed by heap memory */
|
|
|
|
#define _XBF_DELWRI_Q (1u << 22)/* buffer on a delwri queue */
|
2008-05-19 06:34:42 +00:00
|
|
|
|
2020-06-29 21:48:46 +00:00
|
|
|
/* flags used only as arguments to access routines */
|
2023-08-10 14:48:03 +00:00
|
|
|
/*
|
|
|
|
* Online fsck is scanning the buffer cache for live buffers. Do not warn
|
|
|
|
* about length mismatches during lookups and do not return stale buffers.
|
|
|
|
*/
|
|
|
|
#define XBF_LIVESCAN (1u << 28)
|
2022-07-07 12:05:18 +00:00
|
|
|
#define XBF_INCORE (1u << 29)/* lookup only, return if found in cache */
|
2022-04-20 22:44:59 +00:00
|
|
|
#define XBF_TRYLOCK (1u << 30)/* lock requested, but do not wait */
|
|
|
|
#define XBF_UNMAPPED (1u << 31)/* do not map the buffer */
|
2020-06-29 21:48:46 +00:00
|
|
|
|
2022-07-07 12:05:18 +00:00
|
|
|
|
2010-06-24 01:49:12 +00:00
|
|
|
typedef unsigned int xfs_buf_flags_t;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-12-14 23:14:59 +00:00
|
|
|
#define XFS_BUF_FLAGS \
|
|
|
|
{ XBF_READ, "READ" }, \
|
|
|
|
{ XBF_WRITE, "WRITE" }, \
|
2011-07-08 12:36:32 +00:00
|
|
|
{ XBF_READ_AHEAD, "READ_AHEAD" }, \
|
2016-11-28 03:57:42 +00:00
|
|
|
{ XBF_NO_IOACCT, "NO_IOACCT" }, \
|
2009-12-14 23:14:59 +00:00
|
|
|
{ XBF_ASYNC, "ASYNC" }, \
|
|
|
|
{ XBF_DONE, "DONE" }, \
|
|
|
|
{ XBF_STALE, "STALE" }, \
|
xfs: abort metadata writeback on permanent errors
If we are doing aysnc writeback of metadata, we can get write errors
but have nobody to report them to. At the moment, we simply attempt
to reissue the write from io completion in the hope that it's a
transient error.
When it's not a transient error, the buffer is stuck forever in
this loop, and we cannot break out of it. Eventually, unmount will
hang because the AIL cannot be emptied and everything goes downhill
from them.
To solve this problem, only retry the write IO once before aborting
it. We don't throw the buffer away because some transient errors can
last minutes (e.g. FC path failover) or even hours (thin
provisioned devices that have run out of backing space) before they
go away. Hence we really want to keep trying until we can't try any
more.
Because the buffer was not cleaned, however, it does not get removed
from the AIL and hence the next pass across the AIL will start IO on
it again. As such, we still get the "retry forever" semantics that
we currently have, but we allow other access to the buffer in the
mean time. Meanwhile the filesystem can continue to modify the
buffer and relog it, so the IO errors won't hang the log or the
filesystem.
Now when we are pushing the AIL, we can see all these "permanent IO
error" buffers and we can issue a warning about failures before we
retry the IO. We can also catch these buffers when unmounting an
issue a corruption warning, too.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-12-12 05:34:38 +00:00
|
|
|
{ XBF_WRITE_FAIL, "WRITE_FAIL" }, \
|
2020-06-29 21:48:46 +00:00
|
|
|
{ _XBF_INODES, "INODES" }, \
|
2020-06-29 21:48:46 +00:00
|
|
|
{ _XBF_DQUOTS, "DQUOTS" }, \
|
2022-04-20 22:44:59 +00:00
|
|
|
{ _XBF_LOGRECOVERY, "LOG_RECOVERY" }, \
|
2009-12-14 23:14:59 +00:00
|
|
|
{ _XBF_PAGES, "PAGES" }, \
|
2011-03-25 22:16:45 +00:00
|
|
|
{ _XBF_KMEM, "KMEM" }, \
|
2020-06-29 21:48:46 +00:00
|
|
|
{ _XBF_DELWRI_Q, "DELWRI_Q" }, \
|
|
|
|
/* The following interface flags should never be set */ \
|
2023-08-10 14:48:03 +00:00
|
|
|
{ XBF_LIVESCAN, "LIVESCAN" }, \
|
2022-07-07 12:05:18 +00:00
|
|
|
{ XBF_INCORE, "INCORE" }, \
|
2020-06-29 21:48:46 +00:00
|
|
|
{ XBF_TRYLOCK, "TRYLOCK" }, \
|
|
|
|
{ XBF_UNMAPPED, "UNMAPPED" }
|
xfs: abort metadata writeback on permanent errors
If we are doing aysnc writeback of metadata, we can get write errors
but have nobody to report them to. At the moment, we simply attempt
to reissue the write from io completion in the hope that it's a
transient error.
When it's not a transient error, the buffer is stuck forever in
this loop, and we cannot break out of it. Eventually, unmount will
hang because the AIL cannot be emptied and everything goes downhill
from them.
To solve this problem, only retry the write IO once before aborting
it. We don't throw the buffer away because some transient errors can
last minutes (e.g. FC path failover) or even hours (thin
provisioned devices that have run out of backing space) before they
go away. Hence we really want to keep trying until we can't try any
more.
Because the buffer was not cleaned, however, it does not get removed
from the AIL and hence the next pass across the AIL will start IO on
it again. As such, we still get the "retry forever" semantics that
we currently have, but we allow other access to the buffer in the
mean time. Meanwhile the filesystem can continue to modify the
buffer and relog it, so the IO errors won't hang the log or the
filesystem.
Now when we are pushing the AIL, we can see all these "permanent IO
error" buffers and we can issue a warning about failures before we
retry the IO. We can also catch these buffers when unmounting an
issue a corruption warning, too.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-12-12 05:34:38 +00:00
|
|
|
|
2013-08-28 00:18:06 +00:00
|
|
|
/*
|
|
|
|
* Internal state flags.
|
|
|
|
*/
|
|
|
|
#define XFS_BSTATE_DISPOSE (1 << 0) /* buffer being discarded */
|
2017-05-31 15:22:52 +00:00
|
|
|
#define XFS_BSTATE_IN_FLIGHT (1 << 1) /* I/O in flight */
|
2009-12-14 23:14:59 +00:00
|
|
|
|
2024-02-22 20:42:58 +00:00
|
|
|
struct xfs_buf_cache {
|
|
|
|
spinlock_t bc_lock;
|
|
|
|
struct rhashtable bc_hash;
|
|
|
|
};
|
|
|
|
|
|
|
|
int xfs_buf_cache_init(struct xfs_buf_cache *bch);
|
|
|
|
void xfs_buf_cache_destroy(struct xfs_buf_cache *bch);
|
|
|
|
|
xfs: allow logical-sector sized O_DIRECT
Some time ago, mkfs.xfs started picking the storage physical
sector size as the default filesystem "sector size" in order
to avoid RMW costs incurred by doing IOs at logical sector
size alignments.
However, this means that for a filesystem made with i.e.
a 4k sector size on an "advanced format" 4k/512 disk,
512-byte direct IOs are no longer allowed. This means
that XFS has essentially turned this AF drive into a hard
4K device, from the filesystem on up.
XFS's mkfs-specified "sector size" is really just controlling
the minimum size & alignment of filesystem metadata.
There is no real need to tightly couple XFS's minimal
metadata size to the minimum allowed direct IO size;
XFS can continue doing metadata in optimal sizes, but
still allow smaller DIOs for apps which issue them,
for whatever reason.
This patch adds a new field to the xfs_buftarg, so that
we now track 2 sizes:
1) The metadata sector size, which is the minimum unit and
alignment of IO which will be performed by metadata operations.
2) The device logical sector size
The first is used internally by the file system for metadata
alignment and IOs.
The second is used for the minimum allowed direct IO alignment.
This has passed xfstests on filesystems made with 4k sectors,
including when run under the patch I sent to ignore
XFS_IOC_DIOINFO, and issue 512 DIOs anyway. I also directly
tested end of block behavior on preallocated, sparse, and
existing files when we do a 512 IO into a 4k file on a
4k-sector filesystem, to be sure there were no unexpected
behaviors.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2014-01-21 22:46:23 +00:00
|
|
|
/*
|
|
|
|
* The xfs_buftarg contains 2 notions of "sector size" -
|
|
|
|
*
|
|
|
|
* 1) The metadata sector size, which is the minimum unit and
|
|
|
|
* alignment of IO which will be performed by metadata operations.
|
|
|
|
* 2) The device logical sector size
|
|
|
|
*
|
|
|
|
* The first is specified at mkfs time, and is stored on-disk in the
|
|
|
|
* superblock's sb_sectsize.
|
|
|
|
*
|
|
|
|
* The latter is derived from the underlying device, and controls direct IO
|
|
|
|
* alignment constraints.
|
|
|
|
*/
|
2024-02-22 20:42:44 +00:00
|
|
|
struct xfs_buftarg {
|
2006-01-11 04:39:08 +00:00
|
|
|
dev_t bt_dev;
|
2024-01-23 13:26:24 +00:00
|
|
|
struct file *bt_bdev_file;
|
2006-01-11 04:39:08 +00:00
|
|
|
struct block_device *bt_bdev;
|
2017-08-24 22:12:50 +00:00
|
|
|
struct dax_device *bt_daxdev;
|
2024-02-22 20:43:21 +00:00
|
|
|
struct file *bt_file;
|
2021-11-29 10:21:59 +00:00
|
|
|
u64 bt_dax_part_off;
|
2010-09-22 00:47:20 +00:00
|
|
|
struct xfs_mount *bt_mount;
|
2014-01-21 22:45:52 +00:00
|
|
|
unsigned int bt_meta_sectorsize;
|
|
|
|
size_t bt_meta_sectormask;
|
xfs: allow logical-sector sized O_DIRECT
Some time ago, mkfs.xfs started picking the storage physical
sector size as the default filesystem "sector size" in order
to avoid RMW costs incurred by doing IOs at logical sector
size alignments.
However, this means that for a filesystem made with i.e.
a 4k sector size on an "advanced format" 4k/512 disk,
512-byte direct IOs are no longer allowed. This means
that XFS has essentially turned this AF drive into a hard
4K device, from the filesystem on up.
XFS's mkfs-specified "sector size" is really just controlling
the minimum size & alignment of filesystem metadata.
There is no real need to tightly couple XFS's minimal
metadata size to the minimum allowed direct IO size;
XFS can continue doing metadata in optimal sizes, but
still allow smaller DIOs for apps which issue them,
for whatever reason.
This patch adds a new field to the xfs_buftarg, so that
we now track 2 sizes:
1) The metadata sector size, which is the minimum unit and
alignment of IO which will be performed by metadata operations.
2) The device logical sector size
The first is used internally by the file system for metadata
alignment and IOs.
The second is used for the minimum allowed direct IO alignment.
This has passed xfstests on filesystems made with 4k sectors,
including when run under the patch I sent to ignore
XFS_IOC_DIOINFO, and issue 512 DIOs anyway. I also directly
tested end of block behavior on preallocated, sparse, and
existing files when we do a 512 IO into a 4k file on a
4k-sector filesystem, to be sure there were no unexpected
behaviors.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2014-01-21 22:46:23 +00:00
|
|
|
size_t bt_logical_sectorsize;
|
|
|
|
size_t bt_logical_sectormask;
|
2006-01-11 04:39:08 +00:00
|
|
|
|
2010-11-30 06:27:57 +00:00
|
|
|
/* LRU control structures */
|
2023-09-11 09:44:33 +00:00
|
|
|
struct shrinker *bt_shrinker;
|
2013-08-28 00:18:05 +00:00
|
|
|
struct list_lru bt_lru;
|
xfs: track and serialize in-flight async buffers against unmount
Newly allocated XFS metadata buffers are added to the LRU once the hold
count is released, which typically occurs after I/O completion. There is
no other mechanism at current that tracks the existence or I/O state of
a new buffer. Further, readahead I/O tends to be submitted
asynchronously by nature, which means the I/O can remain in flight and
actually complete long after the calling context is gone. This means
that file descriptors or any other holds on the filesystem can be
released, allowing the filesystem to be unmounted while I/O is still in
flight. When I/O completion occurs, core data structures may have been
freed, causing completion to run into invalid memory accesses and likely
to panic.
This problem is reproduced on XFS via directory readahead. A filesystem
is mounted, a directory is opened/closed and the filesystem immediately
unmounted. The open/close cycle triggers a directory readahead that if
delayed long enough, runs buffer I/O completion after the unmount has
completed.
To address this problem, add a mechanism to track all in-flight,
asynchronous buffers using per-cpu counters in the buftarg. The buffer
is accounted on the first I/O submission after the current reference is
acquired and unaccounted once the buffer is returned to the LRU or
freed. Update xfs_wait_buftarg() to wait on all in-flight I/O before
walking the LRU list. Once in-flight I/O has completed and the workqueue
has drained, all new buffers should have been released onto the LRU.
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
2016-07-20 01:15:28 +00:00
|
|
|
|
|
|
|
struct percpu_counter bt_io_count;
|
2020-05-06 20:25:21 +00:00
|
|
|
struct ratelimit_state bt_ioerror_rl;
|
2024-02-22 20:43:21 +00:00
|
|
|
|
|
|
|
/* built-in cache, if we're not using the perag one */
|
|
|
|
struct xfs_buf_cache bt_cache[];
|
2024-02-22 20:42:44 +00:00
|
|
|
};
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-01-11 04:39:08 +00:00
|
|
|
#define XB_PAGES 2
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-06-22 08:50:08 +00:00
|
|
|
struct xfs_buf_map {
|
|
|
|
xfs_daddr_t bm_bn; /* block number for I/O */
|
|
|
|
int bm_len; /* size of I/O */
|
2023-08-10 14:48:03 +00:00
|
|
|
unsigned int bm_flags;
|
2012-06-22 08:50:08 +00:00
|
|
|
};
|
|
|
|
|
2023-08-10 14:48:03 +00:00
|
|
|
/*
|
|
|
|
* Online fsck is scanning the buffer cache for live buffers. Do not warn
|
|
|
|
* about length mismatches during lookups and do not return stale buffers.
|
|
|
|
*/
|
|
|
|
#define XBM_LIVESCAN (1U << 0)
|
|
|
|
|
2012-06-22 08:50:09 +00:00
|
|
|
#define DEFINE_SINGLE_BUF_MAP(map, blkno, numblk) \
|
|
|
|
struct xfs_buf_map (map) = { .bm_bn = (blkno), .bm_len = (numblk) };
|
|
|
|
|
2012-11-14 06:54:40 +00:00
|
|
|
struct xfs_buf_ops {
|
2016-01-04 05:10:19 +00:00
|
|
|
char *name;
|
2019-02-16 19:47:28 +00:00
|
|
|
union {
|
|
|
|
__be32 magic[2]; /* v4 and v5 on disk magic values */
|
|
|
|
__be16 magic16[2]; /* v4 and v5 on disk magic values */
|
|
|
|
};
|
2012-11-14 06:54:40 +00:00
|
|
|
void (*verify_read)(struct xfs_buf *);
|
|
|
|
void (*verify_write)(struct xfs_buf *);
|
2018-01-08 18:51:08 +00:00
|
|
|
xfs_failaddr_t (*verify_struct)(struct xfs_buf *bp);
|
2012-11-14 06:54:40 +00:00
|
|
|
};
|
|
|
|
|
2020-12-17 00:07:34 +00:00
|
|
|
struct xfs_buf {
|
2010-09-24 09:59:15 +00:00
|
|
|
/*
|
|
|
|
* first cacheline holds all the fields needed for an uncontended cache
|
|
|
|
* hit to be fully processed. The semaphore straddles the cacheline
|
|
|
|
* boundary, but the counter and lock sits on the first cacheline,
|
|
|
|
* which is the only bit that is touched if we hit the semaphore
|
|
|
|
* fast-path on locking.
|
|
|
|
*/
|
2016-12-07 06:36:36 +00:00
|
|
|
struct rhash_head b_rhash_head; /* pag buffer hash node */
|
2021-08-19 01:46:24 +00:00
|
|
|
|
2021-08-19 01:48:54 +00:00
|
|
|
xfs_daddr_t b_rhash_key; /* buffer cache index */
|
2012-04-23 05:58:51 +00:00
|
|
|
int b_length; /* size of buffer in BBs */
|
2010-09-24 09:59:15 +00:00
|
|
|
atomic_t b_hold; /* reference count */
|
2010-12-02 05:30:55 +00:00
|
|
|
atomic_t b_lru_ref; /* lru reclaim ref count */
|
2010-09-24 09:59:15 +00:00
|
|
|
xfs_buf_flags_t b_flags; /* status flags */
|
2006-01-11 04:39:08 +00:00
|
|
|
struct semaphore b_sema; /* semaphore for lockables */
|
2010-09-24 09:59:15 +00:00
|
|
|
|
2012-08-10 18:01:51 +00:00
|
|
|
/*
|
|
|
|
* concurrent access to b_lru and b_lru_flags are protected by
|
|
|
|
* bt_lru_lock and not by b_sema
|
|
|
|
*/
|
2010-12-02 05:30:55 +00:00
|
|
|
struct list_head b_lru; /* lru list */
|
2013-08-28 00:18:06 +00:00
|
|
|
spinlock_t b_lock; /* internal state lock */
|
|
|
|
unsigned int b_state; /* internal state flags */
|
2014-10-01 23:04:31 +00:00
|
|
|
int b_io_error; /* internal IO error state */
|
2006-01-11 04:39:08 +00:00
|
|
|
wait_queue_head_t b_waiters; /* unpin waiters */
|
|
|
|
struct list_head b_list;
|
2010-09-24 09:59:04 +00:00
|
|
|
struct xfs_perag *b_pag; /* contains rbtree root */
|
2019-06-29 02:27:29 +00:00
|
|
|
struct xfs_mount *b_mount;
|
2021-01-23 00:48:19 +00:00
|
|
|
struct xfs_buftarg *b_target; /* buffer target (device) */
|
2006-01-11 04:39:08 +00:00
|
|
|
void *b_addr; /* virtual address of buffer */
|
2014-12-03 22:43:17 +00:00
|
|
|
struct work_struct b_ioend_work;
|
2008-08-13 06:36:11 +00:00
|
|
|
struct completion b_iowait; /* queue for I/O waiters */
|
2019-06-29 02:27:28 +00:00
|
|
|
struct xfs_buf_log_item *b_log_item;
|
2018-01-24 21:38:49 +00:00
|
|
|
struct list_head b_li_list; /* Log items list head */
|
2011-07-13 11:43:49 +00:00
|
|
|
struct xfs_trans *b_transp;
|
2006-01-11 04:39:08 +00:00
|
|
|
struct page **b_pages; /* array of page pointers */
|
|
|
|
struct page *b_page_array[XB_PAGES]; /* inline pages */
|
2012-06-22 08:50:09 +00:00
|
|
|
struct xfs_buf_map *b_maps; /* compound buffer map */
|
2012-12-04 23:18:02 +00:00
|
|
|
struct xfs_buf_map __b_map; /* inline compound buffer map */
|
2012-06-22 08:50:09 +00:00
|
|
|
int b_map_count;
|
2010-09-24 09:59:15 +00:00
|
|
|
atomic_t b_pin_count; /* pin count */
|
|
|
|
atomic_t b_io_remaining; /* #outstanding I/O requests */
|
|
|
|
unsigned int b_page_count; /* size of page array */
|
2021-06-07 01:49:50 +00:00
|
|
|
unsigned int b_offset; /* page offset of b_addr,
|
|
|
|
only for _XBF_KMEM buffers */
|
2014-06-25 04:58:08 +00:00
|
|
|
int b_error; /* error code on I/O */
|
2016-05-18 01:08:15 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* async write failure retry count. Initialised to zero on the first
|
|
|
|
* failure, then when it exceeds the maximum configured without a
|
|
|
|
* success the write is considered to be failed permanently and the
|
|
|
|
* iodone handler will take appropriate action.
|
|
|
|
*
|
2024-09-04 13:04:53 +00:00
|
|
|
* For retry timeouts, we record the jiffy of the first failure. This
|
2016-05-18 01:08:15 +00:00
|
|
|
* means that we can change the retry timeout for buffers already under
|
|
|
|
* I/O and thus avoid getting stuck in a retry loop with a long timeout.
|
|
|
|
*
|
|
|
|
* last_error is used to ensure that we are getting repeated errors, not
|
|
|
|
* different errors. e.g. a block device might change ENOSPC to EIO when
|
|
|
|
* a failure timeout occurs, so we want to re-initialise the error
|
|
|
|
* retry behaviour appropriately when that happens.
|
|
|
|
*/
|
|
|
|
int b_retries;
|
|
|
|
unsigned long b_first_retry_time; /* in jiffies */
|
|
|
|
int b_last_error;
|
|
|
|
|
2012-11-14 06:54:40 +00:00
|
|
|
const struct xfs_buf_ops *b_ops;
|
2022-07-14 02:05:07 +00:00
|
|
|
struct rcu_head b_rcu;
|
2020-12-17 00:07:34 +00:00
|
|
|
};
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Finding and Reading Buffers */
|
2020-01-24 01:01:15 +00:00
|
|
|
int xfs_buf_get_map(struct xfs_buftarg *target, struct xfs_buf_map *map,
|
|
|
|
int nmaps, xfs_buf_flags_t flags, struct xfs_buf **bpp);
|
2020-01-24 01:01:16 +00:00
|
|
|
int xfs_buf_read_map(struct xfs_buftarg *target, struct xfs_buf_map *map,
|
|
|
|
int nmaps, xfs_buf_flags_t flags, struct xfs_buf **bpp,
|
2020-01-24 01:01:20 +00:00
|
|
|
const struct xfs_buf_ops *ops, xfs_failaddr_t fa);
|
2012-06-22 08:50:10 +00:00
|
|
|
void xfs_buf_readahead_map(struct xfs_buftarg *target,
|
2012-11-12 11:54:01 +00:00
|
|
|
struct xfs_buf_map *map, int nmaps,
|
2012-11-14 06:54:40 +00:00
|
|
|
const struct xfs_buf_ops *ops);
|
2012-06-22 08:50:10 +00:00
|
|
|
|
2022-07-07 12:05:18 +00:00
|
|
|
static inline int
|
|
|
|
xfs_buf_incore(
|
|
|
|
struct xfs_buftarg *target,
|
|
|
|
xfs_daddr_t blkno,
|
|
|
|
size_t numblks,
|
|
|
|
xfs_buf_flags_t flags,
|
|
|
|
struct xfs_buf **bpp)
|
|
|
|
{
|
|
|
|
DEFINE_SINGLE_BUF_MAP(map, blkno, numblks);
|
|
|
|
|
|
|
|
return xfs_buf_get_map(target, &map, 1, XBF_INCORE | flags, bpp);
|
|
|
|
}
|
|
|
|
|
2020-01-24 01:01:16 +00:00
|
|
|
static inline int
|
2012-06-22 08:50:10 +00:00
|
|
|
xfs_buf_get(
|
|
|
|
struct xfs_buftarg *target,
|
|
|
|
xfs_daddr_t blkno,
|
2020-01-24 01:01:16 +00:00
|
|
|
size_t numblks,
|
|
|
|
struct xfs_buf **bpp)
|
2012-06-22 08:50:10 +00:00
|
|
|
{
|
|
|
|
DEFINE_SINGLE_BUF_MAP(map, blkno, numblks);
|
2020-01-24 01:01:15 +00:00
|
|
|
|
2020-01-24 01:01:16 +00:00
|
|
|
return xfs_buf_get_map(target, &map, 1, 0, bpp);
|
2012-06-22 08:50:10 +00:00
|
|
|
}
|
|
|
|
|
2020-01-24 01:01:17 +00:00
|
|
|
static inline int
|
2012-06-22 08:50:10 +00:00
|
|
|
xfs_buf_read(
|
|
|
|
struct xfs_buftarg *target,
|
|
|
|
xfs_daddr_t blkno,
|
|
|
|
size_t numblks,
|
2012-11-12 11:54:01 +00:00
|
|
|
xfs_buf_flags_t flags,
|
2020-01-24 01:01:17 +00:00
|
|
|
struct xfs_buf **bpp,
|
2012-11-14 06:54:40 +00:00
|
|
|
const struct xfs_buf_ops *ops)
|
2012-06-22 08:50:10 +00:00
|
|
|
{
|
|
|
|
DEFINE_SINGLE_BUF_MAP(map, blkno, numblks);
|
2020-01-24 01:01:16 +00:00
|
|
|
|
2020-01-24 01:01:20 +00:00
|
|
|
return xfs_buf_read_map(target, &map, 1, flags, bpp, ops,
|
|
|
|
__builtin_return_address(0));
|
2012-06-22 08:50:10 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static inline void
|
|
|
|
xfs_buf_readahead(
|
|
|
|
struct xfs_buftarg *target,
|
|
|
|
xfs_daddr_t blkno,
|
2012-11-12 11:54:01 +00:00
|
|
|
size_t numblks,
|
2012-11-14 06:54:40 +00:00
|
|
|
const struct xfs_buf_ops *ops)
|
2012-06-22 08:50:10 +00:00
|
|
|
{
|
|
|
|
DEFINE_SINGLE_BUF_MAP(map, blkno, numblks);
|
2012-11-14 06:54:40 +00:00
|
|
|
return xfs_buf_readahead_map(target, &map, 1, ops);
|
2012-06-22 08:50:10 +00:00
|
|
|
}
|
2012-04-23 05:58:49 +00:00
|
|
|
|
2022-04-20 22:44:59 +00:00
|
|
|
int xfs_buf_get_uncached(struct xfs_buftarg *target, size_t numblks,
|
|
|
|
xfs_buf_flags_t flags, struct xfs_buf **bpp);
|
2014-10-01 23:05:32 +00:00
|
|
|
int xfs_buf_read_uncached(struct xfs_buftarg *target, xfs_daddr_t daddr,
|
2022-04-20 22:44:59 +00:00
|
|
|
size_t numblks, xfs_buf_flags_t flags, struct xfs_buf **bpp,
|
|
|
|
const struct xfs_buf_ops *ops);
|
2020-09-01 17:55:47 +00:00
|
|
|
int _xfs_buf_read(struct xfs_buf *bp, xfs_buf_flags_t flags);
|
2012-04-23 05:58:49 +00:00
|
|
|
void xfs_buf_hold(struct xfs_buf *bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Releasing Buffers */
|
2020-12-17 00:07:34 +00:00
|
|
|
extern void xfs_buf_rele(struct xfs_buf *);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Locking and Unlocking Buffers */
|
2020-12-17 00:07:34 +00:00
|
|
|
extern int xfs_buf_trylock(struct xfs_buf *);
|
|
|
|
extern void xfs_buf_lock(struct xfs_buf *);
|
|
|
|
extern void xfs_buf_unlock(struct xfs_buf *);
|
2011-07-08 12:36:19 +00:00
|
|
|
#define xfs_buf_islocked(bp) \
|
|
|
|
((bp)->b_sema.count <= 0)
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2020-12-17 00:07:34 +00:00
|
|
|
static inline void xfs_buf_relse(struct xfs_buf *bp)
|
2020-06-29 21:48:46 +00:00
|
|
|
{
|
|
|
|
xfs_buf_unlock(bp);
|
|
|
|
xfs_buf_rele(bp);
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Buffer Read and Write Routines */
|
2011-08-23 08:28:07 +00:00
|
|
|
extern int xfs_bwrite(struct xfs_buf *bp);
|
2020-06-29 21:48:46 +00:00
|
|
|
|
2018-01-08 18:51:02 +00:00
|
|
|
extern void __xfs_buf_ioerror(struct xfs_buf *bp, int error,
|
|
|
|
xfs_failaddr_t failaddr);
|
|
|
|
#define xfs_buf_ioerror(bp, err) __xfs_buf_ioerror((bp), (err), __this_address)
|
2020-01-24 01:01:20 +00:00
|
|
|
extern void xfs_buf_ioerror_alert(struct xfs_buf *bp, xfs_failaddr_t fa);
|
2020-05-06 20:25:19 +00:00
|
|
|
void xfs_buf_ioend_fail(struct xfs_buf *);
|
2019-06-12 15:59:59 +00:00
|
|
|
void xfs_buf_zero(struct xfs_buf *bp, size_t boff, size_t bsize);
|
2020-03-11 17:37:54 +00:00
|
|
|
void __xfs_buf_mark_corrupt(struct xfs_buf *bp, xfs_failaddr_t fa);
|
|
|
|
#define xfs_buf_mark_corrupt(bp) __xfs_buf_mark_corrupt((bp), __this_address)
|
2006-01-11 04:39:08 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Buffer Utility Routines */
|
2015-06-21 23:44:29 +00:00
|
|
|
extern void *xfs_buf_offset(struct xfs_buf *, size_t);
|
2016-02-10 04:01:11 +00:00
|
|
|
extern void xfs_buf_stale(struct xfs_buf *bp);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Delayed Write Buffer Routines */
|
2017-04-21 19:40:44 +00:00
|
|
|
extern void xfs_buf_delwri_cancel(struct list_head *);
|
xfs: on-stack delayed write buffer lists
Queue delwri buffers on a local on-stack list instead of a per-buftarg one,
and write back the buffers per-process instead of by waking up xfsbufd.
This is now easily doable given that we have very few places left that write
delwri buffers:
- log recovery:
Only done at mount time, and already forcing out the buffers
synchronously using xfs_flush_buftarg
- quotacheck:
Same story.
- dquot reclaim:
Writes out dirty dquots on the LRU under memory pressure. We might
want to look into doing more of this via xfsaild, but it's already
more optimal than the synchronous inode reclaim that writes each
buffer synchronously.
- xfsaild:
This is the main beneficiary of the change. By keeping a local list
of buffers to write we reduce latency of writing out buffers, and
more importably we can remove all the delwri list promotions which
were hitting the buffer cache hard under sustained metadata loads.
The implementation is very straight forward - xfs_buf_delwri_queue now gets
a new list_head pointer that it adds the delwri buffers to, and all callers
need to eventually submit the list using xfs_buf_delwi_submit or
xfs_buf_delwi_submit_nowait. Buffers that already are on a delwri list are
skipped in xfs_buf_delwri_queue, assuming they already are on another delwri
list. The biggest change to pass down the buffer list was done to the AIL
pushing. Now that we operate on buffers the trylock, push and pushbuf log
item methods are merged into a single push routine, which tries to lock the
item, and if possible add the buffer that needs writeback to the buffer list.
This leads to much simpler code than the previous split but requires the
individual IOP_PUSH instances to unlock and reacquire the AIL around calls
to blocking routines.
Given that xfsailds now also handle writing out buffers, the conditions for
log forcing and the sleep times needed some small changes. The most
important one is that we consider an AIL busy as long we still have buffers
to push, and the other one is that we do increment the pushed LSN for
buffers that are under flushing at this moment, but still count them towards
the stuck items for restart purposes. Without this we could hammer on stuck
items without ever forcing the log and not make progress under heavy random
delete workloads on fast flash storage devices.
[ Dave Chinner:
- rebase on previous patches.
- improved comments for XBF_DELWRI_Q handling
- fix XBF_ASYNC handling in queue submission (test 106 failure)
- rename delwri submit function buffer list parameters for clarity
- xfs_efd_item_push() should return XFS_ITEM_PINNED ]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2012-04-23 05:58:39 +00:00
|
|
|
extern bool xfs_buf_delwri_queue(struct xfs_buf *, struct list_head *);
|
xfs: force all buffers to be written during btree bulk load
While stress-testing online repair of btrees, I noticed periodic
assertion failures from the buffer cache about buffers with incorrect
DELWRI_Q state. Looking further, I observed this race between the AIL
trying to write out a btree block and repair zapping a btree block after
the fact:
AIL: Repair0:
pin buffer X
delwri_queue:
set DELWRI_Q
add to delwri list
stale buf X:
clear DELWRI_Q
does not clear b_list
free space X
commit
delwri_submit # oops
Worse yet, I discovered that running the same repair over and over in a
tight loop can result in a second race that cause data integrity
problems with the repair:
AIL: Repair0: Repair1:
pin buffer X
delwri_queue:
set DELWRI_Q
add to delwri list
stale buf X:
clear DELWRI_Q
does not clear b_list
free space X
commit
find free space X
get buffer
rewrite buffer
delwri_queue:
set DELWRI_Q
already on a list, do not add
commit
BAD: committed tree root before all blocks written
delwri_submit # too late now
I traced this to my own misunderstanding of how the delwri lists work,
particularly with regards to the AIL's buffer list. If a buffer is
logged and committed, the buffer can end up on that AIL buffer list. If
btree repairs are run twice in rapid succession, it's possible that the
first repair will invalidate the buffer and free it before the next time
the AIL wakes up. Marking the buffer stale clears DELWRI_Q from the
buffer state without removing the buffer from its delwri list. The
buffer doesn't know which list it's on, so it cannot know which lock to
take to protect the list for a removal.
If the second repair allocates the same block, it will then recycle the
buffer to start writing the new btree block. Meanwhile, if the AIL
wakes up and walks the buffer list, it will ignore the buffer because it
can't lock it, and go back to sleep.
When the second repair calls delwri_queue to put the buffer on the
list of buffers to write before committing the new btree, it will set
DELWRI_Q again, but since the buffer hasn't been removed from the AIL's
buffer list, it won't add it to the bulkload buffer's list.
This is incorrect, because the bulkload caller relies on delwri_submit
to ensure that all the buffers have been sent to disk /before/
committing the new btree root pointer. This ordering requirement is
required for data consistency.
Worse, the AIL won't clear DELWRI_Q from the buffer when it does finally
drop it, so the next thread to walk through the btree will trip over a
debug assertion on that flag.
To fix this, create a new function that waits for the buffer to be
removed from any other delwri lists before adding the buffer to the
caller's delwri list. By waiting for the buffer to clear both the
delwri list and any potential delwri wait list, we can be sure that
repair will initiate writes of all buffers and report all write errors
back to userspace instead of committing the new structure.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
2023-12-15 18:03:27 +00:00
|
|
|
void xfs_buf_delwri_queue_here(struct xfs_buf *bp, struct list_head *bl);
|
xfs: on-stack delayed write buffer lists
Queue delwri buffers on a local on-stack list instead of a per-buftarg one,
and write back the buffers per-process instead of by waking up xfsbufd.
This is now easily doable given that we have very few places left that write
delwri buffers:
- log recovery:
Only done at mount time, and already forcing out the buffers
synchronously using xfs_flush_buftarg
- quotacheck:
Same story.
- dquot reclaim:
Writes out dirty dquots on the LRU under memory pressure. We might
want to look into doing more of this via xfsaild, but it's already
more optimal than the synchronous inode reclaim that writes each
buffer synchronously.
- xfsaild:
This is the main beneficiary of the change. By keeping a local list
of buffers to write we reduce latency of writing out buffers, and
more importably we can remove all the delwri list promotions which
were hitting the buffer cache hard under sustained metadata loads.
The implementation is very straight forward - xfs_buf_delwri_queue now gets
a new list_head pointer that it adds the delwri buffers to, and all callers
need to eventually submit the list using xfs_buf_delwi_submit or
xfs_buf_delwi_submit_nowait. Buffers that already are on a delwri list are
skipped in xfs_buf_delwri_queue, assuming they already are on another delwri
list. The biggest change to pass down the buffer list was done to the AIL
pushing. Now that we operate on buffers the trylock, push and pushbuf log
item methods are merged into a single push routine, which tries to lock the
item, and if possible add the buffer that needs writeback to the buffer list.
This leads to much simpler code than the previous split but requires the
individual IOP_PUSH instances to unlock and reacquire the AIL around calls
to blocking routines.
Given that xfsailds now also handle writing out buffers, the conditions for
log forcing and the sleep times needed some small changes. The most
important one is that we consider an AIL busy as long we still have buffers
to push, and the other one is that we do increment the pushed LSN for
buffers that are under flushing at this moment, but still count them towards
the stuck items for restart purposes. Without this we could hammer on stuck
items without ever forcing the log and not make progress under heavy random
delete workloads on fast flash storage devices.
[ Dave Chinner:
- rebase on previous patches.
- improved comments for XBF_DELWRI_Q handling
- fix XBF_ASYNC handling in queue submission (test 106 failure)
- rename delwri submit function buffer list parameters for clarity
- xfs_efd_item_push() should return XFS_ITEM_PINNED ]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2012-04-23 05:58:39 +00:00
|
|
|
extern int xfs_buf_delwri_submit(struct list_head *);
|
|
|
|
extern int xfs_buf_delwri_submit_nowait(struct list_head *);
|
2017-06-15 04:21:45 +00:00
|
|
|
extern int xfs_buf_delwri_pushbuf(struct xfs_buf *, struct list_head *);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2021-08-19 01:46:57 +00:00
|
|
|
static inline xfs_daddr_t xfs_buf_daddr(struct xfs_buf *bp)
|
|
|
|
{
|
|
|
|
return bp->b_maps[0].bm_bn;
|
|
|
|
}
|
|
|
|
|
2017-10-17 21:16:29 +00:00
|
|
|
void xfs_buf_set_ref(struct xfs_buf *bp, int lru_ref);
|
2006-01-11 04:39:08 +00:00
|
|
|
|
2018-05-14 06:10:05 +00:00
|
|
|
/*
|
|
|
|
* If the buffer is already on the LRU, do nothing. Otherwise set the buffer
|
|
|
|
* up with a reference count of 0 so it will be tossed from the cache when
|
|
|
|
* released.
|
|
|
|
*/
|
|
|
|
static inline void xfs_buf_oneshot(struct xfs_buf *bp)
|
|
|
|
{
|
|
|
|
if (!list_empty(&bp->b_lru) || atomic_read(&bp->b_lru_ref) > 1)
|
|
|
|
return;
|
|
|
|
atomic_set(&bp->b_lru_ref, 0);
|
|
|
|
}
|
|
|
|
|
2011-07-22 23:40:27 +00:00
|
|
|
static inline int xfs_buf_ispinned(struct xfs_buf *bp)
|
|
|
|
{
|
|
|
|
return atomic_read(&bp->b_pin_count);
|
|
|
|
}
|
2006-01-11 04:39:08 +00:00
|
|
|
|
2014-02-27 04:17:27 +00:00
|
|
|
static inline int
|
|
|
|
xfs_buf_verify_cksum(struct xfs_buf *bp, unsigned long cksum_offset)
|
|
|
|
{
|
|
|
|
return xfs_verify_cksum(bp->b_addr, BBTOB(bp->b_length),
|
|
|
|
cksum_offset);
|
|
|
|
}
|
|
|
|
|
2014-02-27 04:18:23 +00:00
|
|
|
static inline void
|
|
|
|
xfs_buf_update_cksum(struct xfs_buf *bp, unsigned long cksum_offset)
|
|
|
|
{
|
|
|
|
xfs_update_cksum(bp->b_addr, BBTOB(bp->b_length),
|
|
|
|
cksum_offset);
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Handling of buftargs.
|
|
|
|
*/
|
2021-11-29 10:21:55 +00:00
|
|
|
struct xfs_buftarg *xfs_alloc_buftarg(struct xfs_mount *mp,
|
2024-01-23 13:26:24 +00:00
|
|
|
struct file *bdev_file);
|
2018-04-06 17:09:42 +00:00
|
|
|
extern void xfs_free_buftarg(struct xfs_buftarg *);
|
2021-01-23 00:48:20 +00:00
|
|
|
extern void xfs_buftarg_wait(struct xfs_buftarg *);
|
2021-01-23 00:48:19 +00:00
|
|
|
extern void xfs_buftarg_drain(struct xfs_buftarg *);
|
|
|
|
extern int xfs_setsize_buftarg(struct xfs_buftarg *, unsigned int);
|
2010-02-01 23:13:42 +00:00
|
|
|
|
2006-01-11 04:39:08 +00:00
|
|
|
#define xfs_getsize_buftarg(buftarg) block_size((buftarg)->bt_bdev)
|
|
|
|
#define xfs_readonly_buftarg(buftarg) bdev_read_only((buftarg)->bt_bdev)
|
|
|
|
|
2019-02-06 17:25:29 +00:00
|
|
|
int xfs_buf_reverify(struct xfs_buf *bp, const struct xfs_buf_ops *ops);
|
2019-02-16 19:47:28 +00:00
|
|
|
bool xfs_verify_magic(struct xfs_buf *bp, __be32 dmagic);
|
|
|
|
bool xfs_verify_magic16(struct xfs_buf *bp, __be16 dmagic);
|
2018-10-18 06:20:30 +00:00
|
|
|
|
2024-02-22 20:43:21 +00:00
|
|
|
/* for xfs_buf_mem.c only: */
|
|
|
|
int xfs_init_buftarg(struct xfs_buftarg *btp, size_t logical_sectorsize,
|
|
|
|
const char *descr);
|
|
|
|
void xfs_destroy_buftarg(struct xfs_buftarg *btp);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#endif /* __XFS_BUF_H__ */
|