2008-01-25 03:28:31 +00:00
|
|
|
/*
|
|
|
|
* Contains the CIFS DFS referral mounting routines used for handling
|
|
|
|
* traversal via DFS junction point
|
|
|
|
*
|
|
|
|
* Copyright (c) 2007 Igor Mammedov
|
2008-01-25 10:12:41 +00:00
|
|
|
* Copyright (C) International Business Machines Corp., 2008
|
2008-01-25 03:28:31 +00:00
|
|
|
* Author(s): Igor Mammedov (niallain@gmail.com)
|
2008-01-25 10:12:41 +00:00
|
|
|
* Steve French (sfrench@us.ibm.com)
|
2008-01-25 03:28:31 +00:00
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version
|
|
|
|
* 2 of the License, or (at your option) any later version.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/dcache.h>
|
|
|
|
#include <linux/mount.h>
|
|
|
|
#include <linux/namei.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2008-01-25 03:28:31 +00:00
|
|
|
#include <linux/vfs.h>
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#include "cifsglob.h"
|
|
|
|
#include "cifsproto.h"
|
|
|
|
#include "cifsfs.h"
|
|
|
|
#include "dns_resolve.h"
|
|
|
|
#include "cifs_debug.h"
|
|
|
|
|
2008-04-16 03:56:51 +00:00
|
|
|
static LIST_HEAD(cifs_dfs_automount_list);
|
2008-01-25 03:28:31 +00:00
|
|
|
|
2008-04-24 08:56:07 +00:00
|
|
|
static void cifs_dfs_expire_automounts(struct work_struct *work);
|
|
|
|
static DECLARE_DELAYED_WORK(cifs_dfs_automount_task,
|
|
|
|
cifs_dfs_expire_automounts);
|
|
|
|
static int cifs_dfs_mountpoint_expiry_timeout = 500 * HZ;
|
|
|
|
|
|
|
|
static void cifs_dfs_expire_automounts(struct work_struct *work)
|
|
|
|
{
|
|
|
|
struct list_head *list = &cifs_dfs_automount_list;
|
|
|
|
|
|
|
|
mark_mounts_for_expiry(list);
|
|
|
|
if (!list_empty(list))
|
|
|
|
schedule_delayed_work(&cifs_dfs_automount_task,
|
|
|
|
cifs_dfs_mountpoint_expiry_timeout);
|
|
|
|
}
|
2008-01-25 03:28:31 +00:00
|
|
|
|
2008-04-24 08:56:07 +00:00
|
|
|
void cifs_dfs_release_automount_timer(void)
|
2008-01-25 03:28:31 +00:00
|
|
|
{
|
2008-04-24 08:56:07 +00:00
|
|
|
BUG_ON(!list_empty(&cifs_dfs_automount_list));
|
2010-10-19 15:55:54 +00:00
|
|
|
cancel_delayed_work_sync(&cifs_dfs_automount_task);
|
2008-01-25 03:28:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* cifs_get_share_name - extracts share name from UNC
|
|
|
|
* @node_name: pointer to UNC string
|
|
|
|
*
|
|
|
|
* Extracts sharename form full UNC.
|
|
|
|
* i.e. strips from UNC trailing path that is not part of share
|
|
|
|
* name and fixup missing '\' in the begining of DFS node refferal
|
tree-wide: Assorted spelling fixes
In particular, several occurances of funny versions of 'success',
'unknown', 'therefore', 'acknowledge', 'argument', 'achieve', 'address',
'beginning', 'desirable', 'separate' and 'necessary' are fixed.
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Joe Perches <joe@perches.com>
Cc: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
2010-02-03 00:01:28 +00:00
|
|
|
* if necessary.
|
2009-07-23 19:22:30 +00:00
|
|
|
* Returns pointer to share name on success or ERR_PTR on error.
|
2008-01-25 03:28:31 +00:00
|
|
|
* Caller is responsible for freeing returned string.
|
|
|
|
*/
|
|
|
|
static char *cifs_get_share_name(const char *node_name)
|
|
|
|
{
|
|
|
|
int len;
|
|
|
|
char *UNC;
|
|
|
|
char *pSep;
|
|
|
|
|
|
|
|
len = strlen(node_name);
|
|
|
|
UNC = kmalloc(len+2 /*for term null and additional \ if it's missed */,
|
|
|
|
GFP_KERNEL);
|
|
|
|
if (!UNC)
|
2009-07-23 19:22:30 +00:00
|
|
|
return ERR_PTR(-ENOMEM);
|
2008-01-25 03:28:31 +00:00
|
|
|
|
|
|
|
/* get share name and server name */
|
|
|
|
if (node_name[1] != '\\') {
|
|
|
|
UNC[0] = '\\';
|
|
|
|
strncpy(UNC+1, node_name, len);
|
|
|
|
len++;
|
|
|
|
UNC[len] = 0;
|
|
|
|
} else {
|
|
|
|
strncpy(UNC, node_name, len);
|
|
|
|
UNC[len] = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* find server name end */
|
|
|
|
pSep = memchr(UNC+2, '\\', len-2);
|
|
|
|
if (!pSep) {
|
2010-04-21 03:50:45 +00:00
|
|
|
cERROR(1, "%s: no server name end in node name: %s",
|
|
|
|
__func__, node_name);
|
2008-01-25 03:28:31 +00:00
|
|
|
kfree(UNC);
|
2009-07-23 19:22:30 +00:00
|
|
|
return ERR_PTR(-EINVAL);
|
2008-01-25 03:28:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* find sharename end */
|
|
|
|
pSep++;
|
|
|
|
pSep = memchr(UNC+(pSep-UNC), '\\', len-(pSep-UNC));
|
2008-04-28 23:05:58 +00:00
|
|
|
if (pSep) {
|
|
|
|
/* trim path up to sharename end
|
|
|
|
* now we have share name in UNC */
|
|
|
|
*pSep = 0;
|
2008-01-25 03:28:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return UNC;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
2009-03-18 05:50:07 +00:00
|
|
|
* cifs_compose_mount_options - creates mount options for refferral
|
2008-01-25 03:28:31 +00:00
|
|
|
* @sb_mountdata: parent/root DFS mount options (template)
|
2009-03-18 05:50:07 +00:00
|
|
|
* @fullpath: full path in UNC format
|
2008-10-23 09:58:42 +00:00
|
|
|
* @ref: server's referral
|
2008-01-25 03:28:31 +00:00
|
|
|
* @devname: pointer for saving device name
|
|
|
|
*
|
|
|
|
* creates mount options for submount based on template options sb_mountdata
|
|
|
|
* and replacing unc,ip,prefixpath options with ones we've got form ref_unc.
|
|
|
|
*
|
|
|
|
* Returns: pointer to new mount options or ERR_PTR.
|
|
|
|
* Caller is responcible for freeing retunrned value if it is not error.
|
|
|
|
*/
|
2009-03-18 05:50:07 +00:00
|
|
|
char *cifs_compose_mount_options(const char *sb_mountdata,
|
|
|
|
const char *fullpath,
|
2008-10-23 09:58:42 +00:00
|
|
|
const struct dfs_info3_param *ref,
|
2008-01-25 10:12:41 +00:00
|
|
|
char **devname)
|
2008-01-25 03:28:31 +00:00
|
|
|
{
|
|
|
|
int rc;
|
2008-12-18 01:41:20 +00:00
|
|
|
char *mountdata = NULL;
|
2008-01-25 03:28:31 +00:00
|
|
|
int md_len;
|
|
|
|
char *tkn_e;
|
|
|
|
char *srvIP = NULL;
|
|
|
|
char sep = ',';
|
|
|
|
int off, noff;
|
|
|
|
|
|
|
|
if (sb_mountdata == NULL)
|
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
|
2008-10-23 09:58:42 +00:00
|
|
|
*devname = cifs_get_share_name(ref->node_name);
|
2009-07-23 19:22:30 +00:00
|
|
|
if (IS_ERR(*devname)) {
|
|
|
|
rc = PTR_ERR(*devname);
|
|
|
|
*devname = NULL;
|
|
|
|
goto compose_mount_options_err;
|
|
|
|
}
|
|
|
|
|
2008-01-25 03:28:31 +00:00
|
|
|
rc = dns_resolve_server_name_to_ip(*devname, &srvIP);
|
2010-07-22 17:33:01 +00:00
|
|
|
if (rc < 0) {
|
2010-04-21 03:50:45 +00:00
|
|
|
cERROR(1, "%s: Failed to resolve server part of %s to IP: %d",
|
|
|
|
__func__, *devname, rc);
|
2008-12-18 01:41:20 +00:00
|
|
|
goto compose_mount_options_err;
|
2008-01-25 03:28:31 +00:00
|
|
|
}
|
2008-10-23 09:58:42 +00:00
|
|
|
/* md_len = strlen(...) + 12 for 'sep+prefixpath='
|
|
|
|
* assuming that we have 'unc=' and 'ip=' in
|
|
|
|
* the original sb_mountdata
|
|
|
|
*/
|
2010-07-22 17:33:01 +00:00
|
|
|
md_len = strlen(sb_mountdata) + rc + strlen(ref->node_name) + 12;
|
2008-01-25 03:28:31 +00:00
|
|
|
mountdata = kzalloc(md_len+1, GFP_KERNEL);
|
|
|
|
if (mountdata == NULL) {
|
2008-12-18 01:41:20 +00:00
|
|
|
rc = -ENOMEM;
|
|
|
|
goto compose_mount_options_err;
|
2008-01-25 03:28:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* copy all options except of unc,ip,prefixpath */
|
|
|
|
off = 0;
|
|
|
|
if (strncmp(sb_mountdata, "sep=", 4) == 0) {
|
|
|
|
sep = sb_mountdata[4];
|
|
|
|
strncpy(mountdata, sb_mountdata, 5);
|
|
|
|
off += 5;
|
|
|
|
}
|
2008-10-23 09:58:42 +00:00
|
|
|
|
|
|
|
do {
|
|
|
|
tkn_e = strchr(sb_mountdata + off, sep);
|
|
|
|
if (tkn_e == NULL)
|
|
|
|
noff = strlen(sb_mountdata + off);
|
|
|
|
else
|
|
|
|
noff = tkn_e - (sb_mountdata + off) + 1;
|
|
|
|
|
|
|
|
if (strnicmp(sb_mountdata + off, "unc=", 4) == 0) {
|
2008-01-25 03:28:31 +00:00
|
|
|
off += noff;
|
|
|
|
continue;
|
|
|
|
}
|
2008-10-23 09:58:42 +00:00
|
|
|
if (strnicmp(sb_mountdata + off, "ip=", 3) == 0) {
|
2008-01-25 03:28:31 +00:00
|
|
|
off += noff;
|
|
|
|
continue;
|
|
|
|
}
|
2008-10-23 09:58:42 +00:00
|
|
|
if (strnicmp(sb_mountdata + off, "prefixpath=", 11) == 0) {
|
2008-01-25 03:28:31 +00:00
|
|
|
off += noff;
|
|
|
|
continue;
|
|
|
|
}
|
2008-10-23 09:58:42 +00:00
|
|
|
strncat(mountdata, sb_mountdata + off, noff);
|
2008-01-25 03:28:31 +00:00
|
|
|
off += noff;
|
2008-10-23 09:58:42 +00:00
|
|
|
} while (tkn_e);
|
|
|
|
strcat(mountdata, sb_mountdata + off);
|
2008-01-25 03:28:31 +00:00
|
|
|
mountdata[md_len] = '\0';
|
|
|
|
|
|
|
|
/* copy new IP and ref share name */
|
2008-10-23 09:58:42 +00:00
|
|
|
if (mountdata[strlen(mountdata) - 1] != sep)
|
|
|
|
strncat(mountdata, &sep, 1);
|
|
|
|
strcat(mountdata, "ip=");
|
2008-01-25 03:28:31 +00:00
|
|
|
strcat(mountdata, srvIP);
|
2008-10-23 09:58:42 +00:00
|
|
|
strncat(mountdata, &sep, 1);
|
|
|
|
strcat(mountdata, "unc=");
|
2008-01-25 03:28:31 +00:00
|
|
|
strcat(mountdata, *devname);
|
|
|
|
|
|
|
|
/* find & copy prefixpath */
|
2008-10-23 09:58:42 +00:00
|
|
|
tkn_e = strchr(ref->node_name + 2, '\\');
|
2008-12-18 01:41:20 +00:00
|
|
|
if (tkn_e == NULL) {
|
|
|
|
/* invalid unc, missing share name*/
|
|
|
|
rc = -EINVAL;
|
|
|
|
goto compose_mount_options_err;
|
|
|
|
}
|
2008-10-23 09:58:42 +00:00
|
|
|
|
|
|
|
tkn_e = strchr(tkn_e + 1, '\\');
|
2008-12-18 01:41:20 +00:00
|
|
|
if (tkn_e || (strlen(fullpath) - ref->path_consumed)) {
|
2008-10-23 09:58:42 +00:00
|
|
|
strncat(mountdata, &sep, 1);
|
|
|
|
strcat(mountdata, "prefixpath=");
|
|
|
|
if (tkn_e)
|
|
|
|
strcat(mountdata, tkn_e + 1);
|
2008-12-18 01:41:20 +00:00
|
|
|
strcat(mountdata, fullpath + ref->path_consumed);
|
2008-01-25 03:28:31 +00:00
|
|
|
}
|
|
|
|
|
2010-04-21 03:50:45 +00:00
|
|
|
/*cFYI(1, "%s: parent mountdata: %s", __func__,sb_mountdata);*/
|
|
|
|
/*cFYI(1, "%s: submount mountdata: %s", __func__, mountdata );*/
|
2008-01-25 03:28:31 +00:00
|
|
|
|
|
|
|
compose_mount_options_out:
|
|
|
|
kfree(srvIP);
|
|
|
|
return mountdata;
|
2008-12-18 01:41:20 +00:00
|
|
|
|
|
|
|
compose_mount_options_err:
|
|
|
|
kfree(mountdata);
|
|
|
|
mountdata = ERR_PTR(rc);
|
|
|
|
goto compose_mount_options_out;
|
2008-01-25 03:28:31 +00:00
|
|
|
}
|
|
|
|
|
2010-07-26 18:20:16 +00:00
|
|
|
/**
|
|
|
|
* cifs_dfs_do_refmount - mounts specified path using provided refferal
|
|
|
|
* @cifs_sb: parent/root superblock
|
|
|
|
* @fullpath: full path in UNC format
|
|
|
|
* @ref: server's referral
|
|
|
|
*/
|
|
|
|
static struct vfsmount *cifs_dfs_do_refmount(struct cifs_sb_info *cifs_sb,
|
|
|
|
const char *fullpath, const struct dfs_info3_param *ref)
|
2008-01-25 03:28:31 +00:00
|
|
|
{
|
|
|
|
struct vfsmount *mnt;
|
|
|
|
char *mountdata;
|
2008-01-25 10:12:41 +00:00
|
|
|
char *devname = NULL;
|
2009-03-18 05:50:07 +00:00
|
|
|
|
2010-07-26 18:20:16 +00:00
|
|
|
/* strip first '\' from fullpath */
|
2009-03-18 05:50:07 +00:00
|
|
|
mountdata = cifs_compose_mount_options(cifs_sb->mountdata,
|
|
|
|
fullpath + 1, ref, &devname);
|
2008-01-25 03:28:31 +00:00
|
|
|
|
|
|
|
if (IS_ERR(mountdata))
|
|
|
|
return (struct vfsmount *)mountdata;
|
|
|
|
|
|
|
|
mnt = vfs_kern_mount(&cifs_fs_type, 0, devname, mountdata);
|
|
|
|
kfree(mountdata);
|
|
|
|
kfree(devname);
|
|
|
|
return mnt;
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
static int add_mount_helper(struct vfsmount *newmnt, struct nameidata *nd,
|
|
|
|
struct list_head *mntlist)
|
|
|
|
{
|
|
|
|
/* stolen from afs code */
|
|
|
|
int err;
|
|
|
|
|
|
|
|
mntget(newmnt);
|
2010-01-16 18:06:32 +00:00
|
|
|
err = do_add_mount(newmnt, &nd->path, nd->path.mnt->mnt_flags | MNT_SHRINKABLE, mntlist);
|
2008-01-25 03:28:31 +00:00
|
|
|
switch (err) {
|
|
|
|
case 0:
|
2008-04-24 08:56:07 +00:00
|
|
|
path_put(&nd->path);
|
2008-02-15 03:34:32 +00:00
|
|
|
nd->path.mnt = newmnt;
|
|
|
|
nd->path.dentry = dget(newmnt->mnt_root);
|
2008-04-24 08:56:07 +00:00
|
|
|
schedule_delayed_work(&cifs_dfs_automount_task,
|
|
|
|
cifs_dfs_mountpoint_expiry_timeout);
|
2008-01-25 03:28:31 +00:00
|
|
|
break;
|
|
|
|
case -EBUSY:
|
|
|
|
/* someone else made a mount here whilst we were busy */
|
Add a dentry op to allow processes to be held during pathwalk transit
Add a dentry op (d_manage) to permit a filesystem to hold a process and make it
sleep when it tries to transit away from one of that filesystem's directories
during a pathwalk. The operation is keyed off a new dentry flag
(DCACHE_MANAGE_TRANSIT).
The filesystem is allowed to be selective about which processes it holds and
which it permits to continue on or prohibits from transiting from each flagged
directory. This will allow autofs to hold up client processes whilst letting
its userspace daemon through to maintain the directory or the stuff behind it
or mounted upon it.
The ->d_manage() dentry operation:
int (*d_manage)(struct path *path, bool mounting_here);
takes a pointer to the directory about to be transited away from and a flag
indicating whether the transit is undertaken by do_add_mount() or
do_move_mount() skipping through a pile of filesystems mounted on a mountpoint.
It should return 0 if successful and to let the process continue on its way;
-EISDIR to prohibit the caller from skipping to overmounted filesystems or
automounting, and to use this directory; or some other error code to return to
the user.
->d_manage() is called with namespace_sem writelocked if mounting_here is true
and no other locks held, so it may sleep. However, if mounting_here is true,
it may not initiate or wait for a mount or unmount upon the parameter
directory, even if the act is actually performed by userspace.
Within fs/namei.c, follow_managed() is extended to check with d_manage() first
on each managed directory, before transiting away from it or attempting to
automount upon it.
follow_down() is renamed follow_down_one() and should only be used where the
filesystem deliberately intends to avoid management steps (e.g. autofs).
A new follow_down() is added that incorporates the loop done by all other
callers of follow_down() (do_add/move_mount(), autofs and NFSD; whilst AFS, NFS
and CIFS do use it, their use is removed by converting them to use
d_automount()). The new follow_down() calls d_manage() as appropriate. It
also takes an extra parameter to indicate if it is being called from mount code
(with namespace_sem writelocked) which it passes to d_manage(). follow_down()
ignores automount points so that it can be used to mount on them.
__follow_mount_rcu() is made to abort rcu-walk mode if it hits a directory with
DCACHE_MANAGE_TRANSIT set on the basis that we're probably going to have to
sleep. It would be possible to enter d_manage() in rcu-walk mode too, and have
that determine whether to abort or not itself. That would allow the autofs
daemon to continue on in rcu-walk mode.
Note that DCACHE_MANAGE_TRANSIT on a directory should be cleared when it isn't
required as every tranist from that directory will cause d_manage() to be
invoked. It can always be set again when necessary.
==========================
WHAT THIS MEANS FOR AUTOFS
==========================
Autofs currently uses the lookup() inode op and the d_revalidate() dentry op to
trigger the automounting of indirect mounts, and both of these can be called
with i_mutex held.
autofs knows that the i_mutex will be held by the caller in lookup(), and so
can drop it before invoking the daemon - but this isn't so for d_revalidate(),
since the lock is only held on _some_ of the code paths that call it. This
means that autofs can't risk dropping i_mutex from its d_revalidate() function
before it calls the daemon.
The bug could manifest itself as, for example, a process that's trying to
validate an automount dentry that gets made to wait because that dentry is
expired and needs cleaning up:
mkdir S ffffffff8014e05a 0 32580 24956
Call Trace:
[<ffffffff885371fd>] :autofs4:autofs4_wait+0x674/0x897
[<ffffffff80127f7d>] avc_has_perm+0x46/0x58
[<ffffffff8009fdcf>] autoremove_wake_function+0x0/0x2e
[<ffffffff88537be6>] :autofs4:autofs4_expire_wait+0x41/0x6b
[<ffffffff88535cfc>] :autofs4:autofs4_revalidate+0x91/0x149
[<ffffffff80036d96>] __lookup_hash+0xa0/0x12f
[<ffffffff80057a2f>] lookup_create+0x46/0x80
[<ffffffff800e6e31>] sys_mkdirat+0x56/0xe4
versus the automount daemon which wants to remove that dentry, but can't
because the normal process is holding the i_mutex lock:
automount D ffffffff8014e05a 0 32581 1 32561
Call Trace:
[<ffffffff80063c3f>] __mutex_lock_slowpath+0x60/0x9b
[<ffffffff8000ccf1>] do_path_lookup+0x2ca/0x2f1
[<ffffffff80063c89>] .text.lock.mutex+0xf/0x14
[<ffffffff800e6d55>] do_rmdir+0x77/0xde
[<ffffffff8005d229>] tracesys+0x71/0xe0
[<ffffffff8005d28d>] tracesys+0xd5/0xe0
which means that the system is deadlocked.
This patch allows autofs to hold up normal processes whilst the daemon goes
ahead and does things to the dentry tree behind the automouter point without
risking a deadlock as almost no locks are held in d_manage() and none in
d_automount().
Signed-off-by: David Howells <dhowells@redhat.com>
Was-Acked-by: Ian Kent <raven@themaw.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2011-01-14 18:45:26 +00:00
|
|
|
err = follow_down(&nd->path, false);
|
2008-01-25 03:28:31 +00:00
|
|
|
default:
|
|
|
|
mntput(newmnt);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2008-01-25 10:12:41 +00:00
|
|
|
static void dump_referral(const struct dfs_info3_param *ref)
|
2008-01-25 03:28:31 +00:00
|
|
|
{
|
2010-04-21 03:50:45 +00:00
|
|
|
cFYI(1, "DFS: ref path: %s", ref->path_name);
|
|
|
|
cFYI(1, "DFS: node path: %s", ref->node_name);
|
|
|
|
cFYI(1, "DFS: fl: %hd, srv_type: %hd", ref->flags, ref->server_type);
|
|
|
|
cFYI(1, "DFS: ref_flags: %hd, path_consumed: %hd", ref->ref_flag,
|
|
|
|
ref->path_consumed);
|
2008-01-25 03:28:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static void*
|
|
|
|
cifs_dfs_follow_mountpoint(struct dentry *dentry, struct nameidata *nd)
|
|
|
|
{
|
|
|
|
struct dfs_info3_param *referrals = NULL;
|
|
|
|
unsigned int num_referrals = 0;
|
|
|
|
struct cifs_sb_info *cifs_sb;
|
|
|
|
struct cifsSesInfo *ses;
|
|
|
|
char *full_path = NULL;
|
|
|
|
int xid, i;
|
|
|
|
int rc = 0;
|
|
|
|
struct vfsmount *mnt = ERR_PTR(-ENOENT);
|
2010-09-29 23:51:11 +00:00
|
|
|
struct tcon_link *tlink;
|
2008-01-25 03:28:31 +00:00
|
|
|
|
2010-04-21 03:50:45 +00:00
|
|
|
cFYI(1, "in %s", __func__);
|
2008-01-25 03:28:31 +00:00
|
|
|
BUG_ON(IS_ROOT(dentry));
|
|
|
|
|
|
|
|
xid = GetXid();
|
|
|
|
|
2008-02-15 03:34:32 +00:00
|
|
|
dput(nd->path.dentry);
|
|
|
|
nd->path.dentry = dget(dentry);
|
2008-01-25 03:28:31 +00:00
|
|
|
|
2008-12-18 01:41:20 +00:00
|
|
|
/*
|
|
|
|
* The MSDFS spec states that paths in DFS referral requests and
|
|
|
|
* responses must be prefixed by a single '\' character instead of
|
|
|
|
* the double backslashes usually used in the UNC. This function
|
|
|
|
* gives us the latter, so we must adjust the result.
|
|
|
|
*/
|
2008-05-16 09:10:32 +00:00
|
|
|
full_path = build_path_from_dentry(dentry);
|
2008-01-25 03:28:31 +00:00
|
|
|
if (full_path == NULL) {
|
|
|
|
rc = -ENOMEM;
|
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
|
2010-09-29 23:51:11 +00:00
|
|
|
cifs_sb = CIFS_SB(dentry->d_inode->i_sb);
|
|
|
|
tlink = cifs_sb_tlink(cifs_sb);
|
|
|
|
if (IS_ERR(tlink)) {
|
|
|
|
rc = PTR_ERR(tlink);
|
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
ses = tlink_tcon(tlink)->ses;
|
|
|
|
|
|
|
|
rc = get_dfs_path(xid, ses, full_path + 1, cifs_sb->local_nls,
|
2008-01-25 03:28:31 +00:00
|
|
|
&num_referrals, &referrals,
|
|
|
|
cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MAP_SPECIAL_CHR);
|
|
|
|
|
2010-09-29 23:51:11 +00:00
|
|
|
cifs_put_tlink(tlink);
|
|
|
|
|
2008-01-25 03:28:31 +00:00
|
|
|
for (i = 0; i < num_referrals; i++) {
|
2009-05-01 03:50:42 +00:00
|
|
|
int len;
|
2008-01-25 03:28:31 +00:00
|
|
|
dump_referral(referrals+i);
|
2009-03-17 16:00:30 +00:00
|
|
|
/* connect to a node */
|
|
|
|
len = strlen(referrals[i].node_name);
|
|
|
|
if (len < 2) {
|
2010-04-21 03:50:45 +00:00
|
|
|
cERROR(1, "%s: Net Address path too short: %s",
|
|
|
|
__func__, referrals[i].node_name);
|
2009-03-17 16:00:30 +00:00
|
|
|
rc = -EINVAL;
|
|
|
|
goto out_err;
|
|
|
|
}
|
2010-07-26 18:20:16 +00:00
|
|
|
mnt = cifs_dfs_do_refmount(cifs_sb,
|
|
|
|
full_path, referrals + i);
|
2010-04-21 03:50:45 +00:00
|
|
|
cFYI(1, "%s: cifs_dfs_do_refmount:%s , mnt:%p", __func__,
|
|
|
|
referrals[i].node_name, mnt);
|
2008-01-25 03:28:31 +00:00
|
|
|
|
2009-03-17 16:00:30 +00:00
|
|
|
/* complete mount procedure if we accured submount */
|
|
|
|
if (!IS_ERR(mnt))
|
|
|
|
break;
|
2008-01-25 03:28:31 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* we need it cause for() above could exit without valid submount */
|
|
|
|
rc = PTR_ERR(mnt);
|
|
|
|
if (IS_ERR(mnt))
|
|
|
|
goto out_err;
|
|
|
|
|
|
|
|
rc = add_mount_helper(mnt, nd, &cifs_dfs_automount_list);
|
|
|
|
|
|
|
|
out:
|
|
|
|
FreeXid(xid);
|
|
|
|
free_dfs_info_array(referrals, num_referrals);
|
|
|
|
kfree(full_path);
|
2010-04-21 03:50:45 +00:00
|
|
|
cFYI(1, "leaving %s" , __func__);
|
2008-01-25 03:28:31 +00:00
|
|
|
return ERR_PTR(rc);
|
|
|
|
out_err:
|
2008-02-15 03:34:35 +00:00
|
|
|
path_put(&nd->path);
|
2008-01-25 03:28:31 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-09-22 00:01:11 +00:00
|
|
|
const struct inode_operations cifs_dfs_referral_inode_operations = {
|
2008-01-25 03:28:31 +00:00
|
|
|
.follow_link = cifs_dfs_follow_mountpoint,
|
|
|
|
};
|
|
|
|
|